Skip to content

fixing performance bug in Perl implementation#68

Open
getify wants to merge 6 commits intoperlfrom
fix-perf-perl
Open

fixing performance bug in Perl implementation#68
getify wants to merge 6 commits intoperlfrom
fix-perf-perl

Conversation

@getify
Copy link
Owner

@getify getify commented Dec 15, 2021

See #64

NOTE: this is not yet ready, as there's still a FIXME to resolve on this line: f80d978#diff-67dad0d447d0301fffaaab6e42c4cf7129200818c5edbf19531fd115eb2f098bR127

@getify
Copy link
Owner Author

getify commented Dec 15, 2021

Hmmm, so seems tests are failing here? Bummer.

@yurikhan
Copy link

Ha, yes. substr expects its third argument to specify substring length, not end position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants