This repository was archived by the owner on Dec 7, 2020. It is now read-only.
Contributing section#95
Open
legodude17 wants to merge 3 commits intogetify:masterfrom
legodude17:contributing-section
Open
Contributing section#95legodude17 wants to merge 3 commits intogetify:masterfrom legodude17:contributing-section
legodude17 wants to merge 3 commits intogetify:masterfrom
legodude17:contributing-section
Conversation
Author
Owner
|
I am sorry I never circled back to provide feedback here. What occurs to me, glancing at this, is that perhaps the best division of concerns should be that the main repo's README should not include the actual information about building contrib, but rather should mention the contrib-build and link to that section under the contrib README. The reason I feel this way is that while both of these are in the same repo on github, they are separate packages in npm, so I don't want to clutter up too much of the main package's README with info about another package that someone wouldn't necessarily have. A mention and link would seem a nice convenience, though. Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a contributing section and updates the build section.