Skip to content

test pipeline #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AGMETEOR wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test pipeline #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ruleset/rule_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ func testStart(t *testing.T, ctx context.Context, mRuleSet *MutableRuleSet, rsTa
rule := mRuleSet.rules[0].(*ruleWrapper)
require.Equal(t, rule.name, rsTag, "rule name mismatch")
require.Contains(t, mRuleSet.filter.Domain, domain, "rule not loaded")
require.Contains(t, mRuleSet.filter.Domain, domain, "rule not loaded")
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assertion is a duplicate of line 133 and provides no additional test coverage. The same condition is being checked twice with identical parameters and error message. Remove this duplicate line to improve test maintainability.

Suggested change
require.Contains(t, mRuleSet.filter.Domain, domain, "rule not loaded")

Copilot uses AI. Check for mistakes.
}

func testMatch(
Expand Down
Loading