Skip to content

Add build tags to CI test workflow#8510

Merged
myleshorton merged 1 commit intomainfrom
ci-add-build-tags
Mar 5, 2026
Merged

Add build tags to CI test workflow#8510
myleshorton merged 1 commit intomainfrom
ci-add-build-tags

Conversation

@myleshorton
Copy link
Contributor

Summary

  • Add with_clash_api,with_conntrack build tags to the go test command in go.yml
  • The Makefile already uses these tags (line 106) for all production builds, but CI tests were running without them
  • Without with_conntrack, connection tracking is disabled and code paths like graceful connection draining (Add graceful connection draining on tunnel close radiance#350) are never exercised in CI

Test plan

  • Tags match what the Makefile already uses for production builds
  • CI passes with the new tags

🤖 Generated with Claude Code

The Makefile already uses these tags for all production builds, but
the go.yml CI workflow ran tests without them. This meant conntrack
(connection tracking) was disabled in tests, so code paths like
graceful connection draining were never exercised in CI.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@myleshorton myleshorton merged commit f9cdb26 into main Mar 5, 2026
9 checks passed
@myleshorton myleshorton deleted the ci-add-build-tags branch March 5, 2026 19:17
atavism added a commit that referenced this pull request Mar 9, 2026
* Sync private server with radiance.

* Add back account updates

* Added support delete server

* Added split tunnling methods

* Remove unused methods

* Remove unused code

* Add with_clash_api,with_conntrack build tags to CI tests (#8510)

The Makefile already uses these tags for all production builds, but
the go.yml CI workflow ran tests without them. This meant conntrack
(connection tracking) was disabled in tests, so code paths like
graceful connection draining were never exercised in CI.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

* remove pre-releases sooner and more thoroughly (#8506)

* remove pre-releases sooner and more thoroughly

* allow non-main nightlies, but cleanup the release

* don't make releases for nightly builds, either

* added support for ServerCredential and fixed UI issues

* more update

* OAuth account updates (#8513)

* update delete account flow

* save OAuth provider and map to delete account

* Fixed some more Oauth issues

* Fix issue on while signup using OAuth

* use remote radiance

* update IOS method channel

* Update lantern_generated_bindings.dart

* code review updates

* More improvements

* ran format

* fix animaiton issue

* more imporvements

* fix account issue

* update radiance with OAuth fix

* Fix account delete dialog

* Update en.po

* Match last build version and number

* code review updates (#8514)

---------

Co-authored-by: atavism <atavism@users.noreply.github.com>

* be selective on paths when running ci (#8507)

* centerlize local saving logic

* Remove more unused code

* code review updates

* ran format

* update radiance

* Update ffi.go

* remove duplication.

---------

Co-authored-by: Myles Horton <afisk@getlantern.org>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com>
Co-authored-by: atavism <atavism@users.noreply.github.com>
jigar-f added a commit that referenced this pull request Mar 18, 2026
* integrate radiance direct updates

* update Podfile.lock

* update comment

* remove unused

* Tweaked protocols description

* onboarding cleanup

* Added step to windows build and link to dev README (#8448)

* Added windows build step

* Added link to dev README

* Fix windows paths (#8449)

* Added windows build step

* Added link to dev README

* Fixed windows paths

* Fixed space in comment

* Add navigation from tray directly to the join server page (#8451)

* Fixes the blank screen if the user chooses to Connect Now during onboarding (#8453)

* Added ability to upgrade to pro from the tray (#8452)

* Select server location from menu bar (#8454)

* Select server location from menu bar

* Improve readability and check extension status.

* Merge main

---------

Co-authored-by: Jigar-f <jigar@getlantern.org>

* merge latest

* cleanup private server wiring

* remove objectbox remnants and persist app settings

* address review feedback for purchase check

* Sync user follow up (#8509)

* Sync private server with radiance.

* Add back account updates

* Added support delete server

* Added split tunnling methods

* Remove unused methods

* Remove unused code

* Add with_clash_api,with_conntrack build tags to CI tests (#8510)

The Makefile already uses these tags for all production builds, but
the go.yml CI workflow ran tests without them. This meant conntrack
(connection tracking) was disabled in tests, so code paths like
graceful connection draining were never exercised in CI.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

* remove pre-releases sooner and more thoroughly (#8506)

* remove pre-releases sooner and more thoroughly

* allow non-main nightlies, but cleanup the release

* don't make releases for nightly builds, either

* added support for ServerCredential and fixed UI issues

* more update

* OAuth account updates (#8513)

* update delete account flow

* save OAuth provider and map to delete account

* Fixed some more Oauth issues

* Fix issue on while signup using OAuth

* use remote radiance

* update IOS method channel

* Update lantern_generated_bindings.dart

* code review updates

* More improvements

* ran format

* fix animaiton issue

* more imporvements

* fix account issue

* update radiance with OAuth fix

* Fix account delete dialog

* Update en.po

* Match last build version and number

* code review updates (#8514)

---------

Co-authored-by: atavism <atavism@users.noreply.github.com>

* be selective on paths when running ci (#8507)

* centerlize local saving logic

* Remove more unused code

* code review updates

* ran format

* update radiance

* Update ffi.go

* remove duplication.

---------

Co-authored-by: Myles Horton <afisk@getlantern.org>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com>
Co-authored-by: atavism <atavism@users.noreply.github.com>

* sync ffigen with go ffi exports

* code review updates

* Show macos extension dialog if not installed

* ran mode tidy

* Fixed small UI issue

* fix join private server issue

* fix merge conflicts

* upgrade radiance and added back server location chanegs

---------

Co-authored-by: myleshorton <myles@getlantern.org>
Co-authored-by: Jigar-f <jigar@getlantern.org>
Co-authored-by: Myles Horton <afisk@getlantern.org>
Co-authored-by: jigar-f <132374182+jigar-f@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant