Wire BanditURLOverrides through to MutableURLTest by myleshorton · Pull Request #333 · getlantern/radiance

myleshorton · 2026-02-20T17:11:23Z

Summary

Passes BanditURLOverrides from config response through to sing-box MutableURLTestOutboundOptions.URLOverrides
Updates urlTestOutbound() and appendGroupOutbounds() to accept and forward urlOverrides map[string]string
Lantern server group gets bandit overrides; user group and autoAll pass nil
Updates go.mod to reference common and lantern-box bandit-url-overrides branches

Test plan

go vet ./vpn/... passes
Existing TestConnection and TestUpdateServers still pass
Verify MutableURLTest uses per-proxy callback URLs when overrides are present

🤖 Generated with Claude Code

Pass per-proxy callback URLs from config response through to sing-box MutableURLTest URLOverrides, enabling per-ISP bandit proxy assignment on the client side. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR threads BanditURLOverrides from the loaded config through to Lantern’s MutableURLTestOutboundOptions.URLOverrides, enabling per-proxy URL test callback overrides to reach the sing-box mutable URL test implementation.

Changes:

Extend urlTestOutbound() and appendGroupOutbounds() to accept urlOverrides map[string]string and forward it into MutableURLTestOutboundOptions.URLOverrides.
Pass cfg.BanditURLOverrides into the Lantern server group’s URL test outbound; keep User/All URL test outbounds using nil.
Update module dependencies (go.mod/go.sum) to versions/branches that include the new options surface.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
vpn/vpn.go	Updates pre-start URL test outbound construction to the new `urlTestOutbound` signature (currently passing `nil` overrides).
vpn/tunnel_test.go	Updates tests to call `urlTestOutbound` with the new signature.
vpn/boxoptions.go	Wires `BanditURLOverrides` into the Lantern group’s MutableURLTest outbound and adds `URLOverrides` to the outbound options.
go.mod	Bumps `common`/`lantern-box` (and other deps) to versions needed for the new override option surface.
go.sum	Corresponding checksum updates after dependency changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vpn/vpn.go

vpn/boxoptions.go

go.mod

Forward cfg.BanditURLOverrides into the preTest urlTestOutbound so bandit callback URLs are used during pre-start URL testing, not just during normal operation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Verify that URLOverrides from config.BanditURLOverrides are correctly forwarded into the auto-lantern MutableURLTestOutboundOptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Periodically reports per-outbound throughput to the bandit system so it can optimize for actual download speed, not just connectivity. Interval and body size are randomized to avoid creating a fingerprintable signal. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…sts" This reverts commit 7b3bd80.

garmr-ulfr · 2026-02-24T20:04:20Z

@myleshorton are the BanditURLOverrides specific to each proxy, meaning each new config will contain new override URLs? If that's the case, do they need to be? The existing overrides will become invalid once we receive a new config.

myleshorton · 2026-02-24T20:11:27Z

@myleshorton are the BanditURLOverrides specific to each proxy, meaning each new config will contain new override URLs? If that's the case, do they need to be? The existing overrides will become invalid once we receive a new config.

Basically each config response is a test for each "arm" of the multi-armed bandit, so each URL has a token for that test that allows the server to identify it when the client makes the callback. So each proxy gets its own token essentially.

garmr-ulfr · 2026-02-24T20:23:15Z

Gotcha. Then they'll become invalid as soon as we receive a new config... We could add a field, (URLTester??), to MutableURLTestOptions to specify which tester implementation to use. Then we can implement a bandit-based tester that supports updating tokens dynamically when the config changes.

myleshorton · 2026-02-24T21:16:52Z

I don't quite understand the problem sorry. What's bad about them becoming invalid?

garmr-ulfr · 2026-02-24T21:25:10Z

When a new config is received, won't it have new override URLs that are specific to the new proxies?

myleshorton · 2026-02-24T21:26:22Z

Yeah, but that's what we want -- that means the server wants to test those.

myleshorton · 2026-02-24T21:26:51Z

This might be helpful:

https://github.com/getlantern/lantern-cloud/blob/bandit-url-overrides/docs/src/concepts/bandit.md

garmr-ulfr · 2026-02-24T21:38:52Z

Yeah, but that's what we want -- that means the server wants to test those.

Right, so when we get a new config while the VPN is connected, we update the outbounds/endpoints and just add the new tags to the MutableURLTest outbounds. Since they're not recreated, they won't have the new override URLs.

myleshorton · 2026-02-24T22:14:26Z

Oh sorry I misunderstood! OK, I should be able to fix that.

Persist URLOverrides in servers.Options so they survive file-watcher reloads, and call SetURLOverrides in updateGroup so new proxies from a config refresh get their bandit callback URLs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

myleshorton · 2026-02-25T22:44:39Z

OK that last commit implements a fairly straightforward solution I think?

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vpn/tunnel.go

servers/manager.go

- Fix URLOverrides lost through removeDuplicates: stash overrides before dedup and pass the stashed value to SetURLOverrides - Persist URLOverrides through servers.Manager: clone in setServers and Servers so overrides survive save/load round-trips - go.sum updated by go mod tidy Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The merge() function rebuilds Options without carrying URLOverrides, so AddServers would silently drop them. Merge incoming URLOverrides into the existing group's map alongside Locations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

# Conflicts: # go.mod # go.sum # vpn/tunnel.go

Update lantern-box to v0.0.6-0.20260304185010-31f62b643c0e (latest) and resolve go.mod/go.sum merge conflicts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Resolves conflicts in: - servers/manager.go: keep both URLOverrides (bandit) and Credentials (main) fields - go.mod/go.sum: take main's kindling and lantern-box versions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- boxoptions.go: Reduce URL test interval from 3min to 15s so bandit callbacks arrive within the 20s probe expiry window. Reduce idle timeout from 15min to 5min. - tunnel.go: Log when bandit URL overrides are applied to a URL test group, including the override count. - config.go: Log when config response includes bandit URL overrides with counts for overrides, outbounds, and endpoints. The 3-minute interval was the root cause of high failure rates — probes expire in 20s but the client wouldn't test until 3 minutes later, so the reaper always recorded reward=0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

… interval Instead of lowering the URL test interval globally (which increases traffic for all users), trigger CheckOutbounds() immediately when a new config with bandit URL overrides arrives from the API. This fires the callbacks within seconds of probe creation. - tunnel.go: After SetURLOverrides, call CheckOutbounds to fire an immediate URL test cycle. Log override application and trigger. - config.go: Log when config response includes bandit URL overrides. - go.mod: Update lantern-box to include OutboundChecker interface. The URL test interval stays at 3 minutes for normal operation. Callbacks only need to be fast on initial config receipt. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vpn/tunnel.go

config/fetcher.go

README.md

- tunnel.go: Carry URLOverrides and Credentials through removeDuplicates so bandit overrides aren't silently dropped (fixes review comment) - tunnel.go: Only trigger CheckOutbounds after SetURLOverrides succeeds to avoid testing against default URLs on failure - fetcher.go: Guard RADIANCE_FEATURE_OVERRIDE with non-empty check to avoid sending an empty X-Lantern-Feature-Override header - README.md: Clarify that feature override works in any environment, not just non-prod Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

garmr-ulfr

LGTM!

Wire BanditURLOverrides through to MutableURLTest

4e99a20

Pass per-proxy callback URLs from config response through to sing-box MutableURLTest URLOverrides, enabling per-ISP bandit proxy assignment on the client side. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings February 20, 2026 17:11

Copilot started reviewing on behalf of myleshorton February 20, 2026 17:11 View session

Copilot AI reviewed Feb 20, 2026

View reviewed changes

vpn/vpn.go Outdated Show resolved Hide resolved

vpn/boxoptions.go Show resolved Hide resolved

go.mod Show resolved Hide resolved

myleshorton and others added 5 commits February 20, 2026 11:06

Pass BanditURLOverrides to preTest URL tests

bba0b2e

Forward cfg.BanditURLOverrides into the preTest urlTestOutbound so bandit callback URLs are used during pre-start URL testing, not just during normal operation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add test for BanditURLOverrides wiring in buildOptions

823eb1d

Verify that URLOverrides from config.BanditURLOverrides are correctly forwarded into the auto-lantern MutableURLTestOutboundOptions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Revert "Add throughput reporter with jittered timing and padded reque…

adf8ba5

…sts" This reverts commit 7b3bd80.

Updated to mainline of lantern-box

94f125c

myleshorton requested a review from garmr-ulfr February 24, 2026 19:46

myleshorton requested a review from Copilot February 25, 2026 22:47

Copilot started reviewing on behalf of myleshorton February 25, 2026 22:47 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

vpn/tunnel.go Outdated Show resolved Hide resolved

servers/manager.go Show resolved Hide resolved

myleshorton marked this pull request as draft February 26, 2026 00:11

myleshorton and others added 5 commits February 25, 2026 17:20

updated to latest lantern-box and added feature override for testing

12c4425

Updated README with RADIANCE_FEATURE_OVERRIDE details

890c832

Merge remote-tracking branch 'origin/main' into bandit-url-overrides

f82b6c0

# Conflicts: # go.mod # go.sum # vpn/tunnel.go

Merge remote-tracking branch 'origin/main' into bandit-url-overrides

f7f542c

Update lantern-box to v0.0.6-0.20260304185010-31f62b643c0e (latest) and resolve go.mod/go.sum merge conflicts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

myleshorton marked this pull request as ready for review March 6, 2026 22:17

myleshorton and others added 3 commits March 23, 2026 08:59

Merge main into bandit-url-overrides

6941692

Resolves conflicts in: - servers/manager.go: keep both URLOverrides (bandit) and Credentials (main) fields - go.mod/go.sum: take main's kindling and lantern-box versions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

myleshorton requested a review from Copilot March 23, 2026 16:23

Copilot started reviewing on behalf of myleshorton March 23, 2026 16:24 View session

Copilot AI reviewed Mar 23, 2026

View reviewed changes

vpn/tunnel.go Show resolved Hide resolved

config/fetcher.go Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

garmr-ulfr approved these changes Mar 23, 2026

View reviewed changes

myleshorton mentioned this pull request Mar 23, 2026

Add OutboundChecker interface for on-demand URL testing getlantern/lantern-box#195

Merged

3 tasks

myleshorton merged commit fe47753 into main Mar 23, 2026
2 checks passed

myleshorton deleted the bandit-url-overrides branch March 23, 2026 16:52

Conversation

myleshorton commented Feb 20, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

garmr-ulfr commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

garmr-ulfr commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

garmr-ulfr commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

garmr-ulfr commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 24, 2026

Uh oh!

myleshorton commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

garmr-ulfr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

garmr-ulfr commented Feb 24, 2026 •

edited

Loading