fix: ensure connections are closed after sync operations#355
Merged
MatLBS merged 2 commits intogetnao:mainfrom Mar 3, 2026
Merged
fix: ensure connections are closed after sync operations#355MatLBS merged 2 commits intogetnao:mainfrom
MatLBS merged 2 commits intogetnao:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="cli/nao_core/commands/sync/providers/databases/provider.py">
<violation number="1" location="cli/nao_core/commands/sync/providers/databases/provider.py:64">
P2: The `try` block should start immediately after `conn = db_config.connect()` to guarantee `conn.disconnect()` runs in the `finally` even if the intervening `console.print(...)` raises. As written, an exception in `console.print` would leak the connection — the exact bug this PR aims to fix.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Bl3f
pushed a commit
to rsivapr/nao
that referenced
this pull request
Mar 4, 2026
* fix: ensure connections are closed after sync operations * refactor: move connection message inside try block for clarity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
syncs or large projects