add mysql backend support by teoria · Pull Request #393 · getnao/nao

teoria · 2026-03-03T02:27:00Z

#211
add mysql backend support

Bl3f

Look almost good to me thank you so much. Can you as well add an integration test for MySQL like the other providers in cli/tests/nao_core/commands/sync/integration folder?

Bl3f · 2026-03-04T15:03:49Z

@@ -0,0 +1,20 @@
+services:


instead of creating this, the best would be to merge into a docker-compose.test.yml every database that can be embed in a Docker component, so we don't finish with an endless list of docker-compose files.

Jayjaejae · 2026-03-16T17:00:02Z

@teoria Could you share any update on this pr? I also need MySQL support!

teoria · 2026-03-16T18:40:51Z

@teoria Could you share any update on this pr? I also need MySQL support!

I needed to add a new dependency to the Dockerfile.
I'll update the PR now.
Thanks for reminding me.

teoria · 2026-03-18T00:40:18Z

name: mysql_prod
type: mysql
host: ${MYSQL_HOST:-localhost}
port: 3306
database: ${MYSQL_DATABASE}
user: ${MYSQL_USER}
password: ${MYSQL_PASSWORD}

Signed-off-by: Rodrigo Carneiro <teoria@gmail.com>

…to feat/211-add_mysql_support

github-actions · 2026-03-18T01:10:42Z

🧹 Preview Removed

The preview deployment for this PR has been cleaned up.

cubic-dev-ai

2 issues found across 8 files

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Dockerfile">

<violation number="1" location="Dockerfile:72">
P1: MySQL/MariaDB client library is only installed in builder stage, so compiled MySQL Python backend can fail at runtime due to missing shared libs in final image.</violation>
</file>

<file name="cli/tests/nao_core/commands/sync/integration/test_mysql.py">

<violation number="1" location="cli/tests/nao_core/commands/sync/integration/test_mysql.py:68">
P2: MySQL integration fixture suppresses SQL seed failures, allowing setup to continue with a potentially incomplete database.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-03-19T09:14:40Z

+    gcc \
    unixodbc-dev \
+    pkg-config \
+    libmariadb-dev \


P1: MySQL/MariaDB client library is only installed in builder stage, so compiled MySQL Python backend can fail at runtime due to missing shared libs in final image.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At Dockerfile, line 72: <comment>MySQL/MariaDB client library is only installed in builder stage, so compiled MySQL Python backend can fail at runtime due to missing shared libs in final image.</comment> <file context> @@ -65,9 +65,13 @@ WORKDIR /app + gcc \ unixodbc-dev \ + pkg-config \ + libmariadb-dev \ && rm -rf /var/lib/apt/lists/* - </file context>

cubic-dev-ai · 2026-03-19T09:14:40Z

+            if statement:
+                try:
+                    conn.raw_sql(statement).fetchall()
+                except Exception:


P2: MySQL integration fixture suppresses SQL seed failures, allowing setup to continue with a potentially incomplete database.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At cli/tests/nao_core/commands/sync/integration/test_mysql.py, line 68: <comment>MySQL integration fixture suppresses SQL seed failures, allowing setup to continue with a potentially incomplete database.</comment> <file context> @@ -0,0 +1,144 @@ + if statement: + try: + conn.raw_sql(statement).fetchall() + except Exception: + pass + </file context>

github-actions · 2026-03-19T09:16:54Z

🚀 Preview Deployment


URL	https://pr-393-97c884e.preview.getnao.io
Commit	`97c884e`

⚠️ No LLM API keys configured - you'll see the API key setup flow when trying to chat.

_{Preview will be automatically removed when this PR is closed.}

cubic-dev-ai

2 issues found across 5 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="Dockerfile">

<violation number="1" location="Dockerfile:72">
P1: MySQL client native library is compiled in the builder but missing from runtime image, which can cause MySQL backend import/linker failures at runtime.</violation>
</file>

<file name="cli/nao_core/config/databases/mysql.py">

<violation number="1" location="cli/nao_core/config/databases/mysql.py:20">
P2: MySQL identifier quoting is unsafe because `_quote()` does not escape embedded backticks before interpolating identifiers into raw SQL.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2026-03-19T09:17:08Z

+    gcc \
    unixodbc-dev \
+    pkg-config \
+    libmariadb-dev \


P1: MySQL client native library is compiled in the builder but missing from runtime image, which can cause MySQL backend import/linker failures at runtime.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At Dockerfile, line 72: <comment>MySQL client native library is compiled in the builder but missing from runtime image, which can cause MySQL backend import/linker failures at runtime.</comment> <file context> @@ -65,9 +65,13 @@ WORKDIR /app + gcc \ unixodbc-dev \ + pkg-config \ + libmariadb-dev \ && rm -rf /var/lib/apt/lists/* - </file context>

cubic-dev-ai · 2026-03-19T09:17:08Z

+    """MySQL context with information_schema description discovery."""
+
+    def _quote(self, name: str) -> str:
+        return f"`{name}`"


P2: MySQL identifier quoting is unsafe because _quote() does not escape embedded backticks before interpolating identifiers into raw SQL.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At cli/nao_core/config/databases/mysql.py, line 20: <comment>MySQL identifier quoting is unsafe because `_quote()` does not escape embedded backticks before interpolating identifiers into raw SQL.</comment> <file context> @@ -16,6 +16,9 @@ """MySQL context with information_schema description discovery.""" + def _quote(self, name: str) -> str: + return f"`{name}`" + def description(self) -> str | None: </file context>

Suggested change

return f"`{name}`"

return f"`{name.replace('`', '``')}`"

add mysql backend support

c896093

Bl3f requested changes Mar 4, 2026

View reviewed changes

add integration test

31d67b0

teoria added 6 commits March 17, 2026 21:45

Merge branch 'main' into feat/211-add_mysql_support

c2da34a

Signed-off-by: Rodrigo Carneiro <teoria@gmail.com>

restore postgres compose file

4cf5987

Merge branch 'feat/211-add_mysql_support' of github.com:teoria/nao in…

9e53a43

…to feat/211-add_mysql_support

add mysql build dependencies

866eab6

add mysql build dependencies

768ae7f

add mysql build dependencies gcc

5a3d1f6

Bl3f marked this pull request as ready for review March 19, 2026 08:53

Fix the mysql tests

97c884e

Bl3f merged commit 552a0ba into getnao:main Mar 19, 2026
3 checks passed

cubic-dev-ai Bot reviewed Mar 19, 2026

View reviewed changes

Conversation

teoria commented Mar 3, 2026

Uh oh!

Bl3f left a comment

Choose a reason for hiding this comment

Uh oh!

Bl3f Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Jayjaejae commented Mar 16, 2026

Uh oh!

teoria commented Mar 16, 2026

Uh oh!

teoria commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧹 Preview Removed

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 19, 2026

🚀 Preview Deployment

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Mar 18, 2026 •

edited

Loading

cubic-dev-ai Bot Mar 19, 2026 •

edited

Loading

cubic-dev-ai Bot Mar 19, 2026 •

edited

Loading

cubic-dev-ai Bot Mar 19, 2026 •

edited

Loading

cubic-dev-ai Bot Mar 19, 2026 •

edited

Loading