fix: handle pendingTransactionId and transaction review URLs - #41
Merged
tysonwil merged 2 commits intoMar 16, 2026
Merged
Conversation
…ing methods When a partner has permissions policies enabled and a signing operation requires approval, the backend returns pendingTransactionId instead of a signature. This change adds proper handling for this case: - signMessage/signTransaction now return SigningResult enum (.success/.denied) - Add TransactionDeniedResult with pendingTransactionId and transactionReviewUrl - Add setTransactionReviewHandler() for auto-opening review URLs in-app - Update signSolanaSerializedTransaction return type to match Ref: ENG-6540 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…enum Reverts the SigningResult enum approach. Instead, signing methods keep their existing SignatureResult return type and throw ParaError.transactionDenied when a permissions policy blocks the operation. No breaking API changes. - Add ParaError.transactionDenied(pendingTransactionId:, transactionReviewUrl:) - Add setTransactionReviewHandler() — auto-opens review URL before throwing - Add checkForTransactionDenial() helper in signing methods Ref: ENG-6540 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
jlm0
approved these changes
Mar 16, 2026
tysonwil
deleted the
tyson/eng-6540-swift-flutter-sdks-handle-pendingtransactionid-and
branch
March 16, 2026 23:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ParaError.transactionDeniederror case — thrown when a permissions policy blocks signingsetTransactionReviewHandler()— registers a handler that auto-opens the review URL before throwingcheckForTransactionDenial()private helper in signing methodsTest plan
Ref: ENG-6540
🤖 Generated with Claude Code