Skip to content

feat: add Stellar wallet support - #44

Merged
tysonwil merged 1 commit into
mainfrom
feat/stellar-swift-sdk
Jun 4, 2026
Merged

feat: add Stellar wallet support#44
tysonwil merged 1 commit into
mainfrom
feat/stellar-swift-sdk

Conversation

@tysonwil

@tysonwil tysonwil commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Problem

Para Swift SDK did not expose Stellar as a wallet type or provide the small Stellar payload/address helpers needed for apps to create, display, and sign with Stellar wallets through the existing bridge.

Solution

  • Add STELLAR wallet/external-wallet type support.
  • Add Stellar G-address derivation from Ed25519 public keys and Solana-style base58 addresses.
  • Add minimal Stellar transaction/memo/network models that encode into the existing bridge signing path.
  • Add focused XCTest coverage for wallet decoding, transaction payload encoding, and address derivation vectors.

Verification

  • xcodebuild -workspace /Users/tyson/para/ParaSwift.xcworkspace -scheme ParaSwift -sdk iphonesimulator -configuration Release build
  • xcodebuild -workspace /Users/tyson/para/ParaSwift.xcworkspace -scheme ParaSwift -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 17,OS=26.5" test
  • swift test is not viable for this package on macOS because the SDK imports UIKit.
  • swiftformat . was not run because swiftformat is not installed locally.

Companion PRs

Notes

Core JS Stellar support already exists from js-monorepo PR #1545 / commit 648f5bb55.

@claude

claude Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error —— View job


I'll analyze this and get back to you.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 32b04ba077

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +140 to +141
if let address {
return try? StellarAddress.fromSolanaAddress(address)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve existing Stellar addresses

When a Stellar wallet has no publicKey and address is already a Stellar G-address (the shape used in the new wallet decoding test), this fallback tries to decode that G-address as a Solana/base58 public key. Stellar strkeys are base32/checksummed and many contain characters not in base58, or decode to the wrong byte length, so wallet.stellarAddress returns nil for an otherwise valid Stellar wallet instead of exposing its usable address.

Useful? React with 👍 / 👎.

@tysonwil
tysonwil merged commit 4d58703 into main Jun 4, 2026
5 of 7 checks passed
@tysonwil
tysonwil deleted the feat/stellar-swift-sdk branch June 4, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants