feat: add Stellar wallet support - #44
Conversation
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32b04ba077
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let address { | ||
| return try? StellarAddress.fromSolanaAddress(address) |
There was a problem hiding this comment.
Preserve existing Stellar addresses
When a Stellar wallet has no publicKey and address is already a Stellar G-address (the shape used in the new wallet decoding test), this fallback tries to decode that G-address as a Solana/base58 public key. Stellar strkeys are base32/checksummed and many contain characters not in base58, or decode to the wrong byte length, so wallet.stellarAddress returns nil for an otherwise valid Stellar wallet instead of exposing its usable address.
Useful? React with 👍 / 👎.
Problem
Para Swift SDK did not expose Stellar as a wallet type or provide the small Stellar payload/address helpers needed for apps to create, display, and sign with Stellar wallets through the existing bridge.
Solution
STELLARwallet/external-wallet type support.Verification
xcodebuild -workspace /Users/tyson/para/ParaSwift.xcworkspace -scheme ParaSwift -sdk iphonesimulator -configuration Release buildxcodebuild -workspace /Users/tyson/para/ParaSwift.xcworkspace -scheme ParaSwift -sdk iphonesimulator -destination "platform=iOS Simulator,name=iPhone 17,OS=26.5" testswift testis not viable for this package on macOS because the SDK imports UIKit.swiftformat .was not run becauseswiftformatis not installed locally.Companion PRs
Notes
Core JS Stellar support already exists from js-monorepo PR #1545 / commit 648f5bb55.