Cancel incomplete signatures and quorums on archive#1431
Draft
gearnode wants to merge 1 commit into
Draft
Conversation
When a document is archived, delete every still-pending signature request and void any pending approval quorum so incomplete workflows do not linger after the document is frozen. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Archiving a document now cancels incomplete workflow items in the same transaction:
REQUESTEDsignature request on any version of the document (same semantics as manual cancel and major publish).DRAFT(same semantics asvoidDocumentVersionApproval).This applies to both
archiveDocumentandbulkArchiveDocuments. Completed signatures and finished approvals are left untouched.Test plan
TestDocumentVersion_ArchiveCancelsPendingSignatureTestDocumentVersion_ArchiveVoidsPendingApprovalSummary by cubic
Archiving a document now cancels incomplete workflows. We delete pending signature requests and void pending approval quorums for both
archiveDocumentandbulkArchiveDocuments, without touching completed records.Tests
+131-0Coredata
+70-0REQUESTEDsignatures by document ID or IDs in one query.Service
+140-31Written for commit 794de68. Summary will update on new commits.