Fix compliance page logo incorrectly set from org settings uploads#1460
Draft
gearnode wants to merge 3 commits into
Draft
Fix compliance page logo incorrectly set from org settings uploads#1460gearnode wants to merge 3 commits into
gearnode wants to merge 3 commits into
Conversation
Organization settings uploads were auto-copying the square logo into trust_centers.logo_file_id on first upload, which could stick a document-oriented horizontal asset on the public compliance page. Serve the organization square logo as a runtime fallback when no dedicated compliance logo is configured, and clear inherited logo file IDs that match organization or horizontal logo files. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
Flatten the fallback branch so blank lines separate the scope load from the following if, matching the console resolver style. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
Inline the scope construction so only one statement precedes the organization load error check. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Bryan FRIMIN <bryan@frimin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ENG-583: uploading a logo in organization settings (especially on first upload) could pin the wrong asset on the public compliance page.
The root cause was an auto-copy in
UpdateOrganizationthat wrote the uploaded organization logo file ID intotrust_centers.logo_file_idwhenever the compliance page had no dedicated logo yet. Once set, later uploads (including horizontal logos for documents) did not update the public page, leaving customers with a stale or incorrect logo.Changes
trust_centers.logo_file_idduring org create/update.organizations.logo_file_id) on the public compliance page, console brand UI, MCP, and email branding paths.trust_centers.logo_file_idvalues that were inherited from organization or horizontal logo file IDs so existing tenants pick up the fallback behavior.Testing
e2e/console/connect_organization_horizontal_logo_test.gomake go-fmtpasses on touched Go filesLinear Issue: ENG-583
Summary by cubic
Fixes ENG-583 by ensuring org settings uploads no longer override the compliance page logo. Removes the auto-copy and serves the org square logo as a fallback when no compliance logo is set, with a migration to clear inherited values.
Tests
+212-0Coredata
+43-0TrustCenter.EffectiveLogoFileIDto resolve the active logo (trust-center-specific or org square).trust_centers.logo_file_idwhen it matches org logo IDs.Service
+58-53EffectiveLogoFileIDfor logo resolution in compliance page, email branding, and mailing lists.GraphQL API
+39-5MCP
+7-2EffectiveLogoFileIDso MCP reflects the same fallback behavior.Written for commit ca946c8. Summary will update on new commits.