Compliance portal auth#1487
Draft
codenem wants to merge 4 commits into
Draft
Conversation
The compliance portal's "Get Access" button was inert and the portal had no way to authenticate or request trust-center access. Add a modal sign-in flow (magic link + OIDC) that gates the requestAllAccesses mutation, mirroring the trust app's flow but as a dialog instead of a full /connect page. Introduce the two v2 UI-kit primitives this depends on: a headless Base UI Dialog and a styled Toaster (mutation toasts had no host yet). Wire the top-bar button to open the dialog, resume the deferred access request once authenticated, and add standalone routes for magic-link verification and the full-name gate. Signed-off-by: Émile Ré <emile@probo.com>
Cover the new v2 kit primitives in Storybook: the Dialog (uncontrolled trigger, controlled open state, and skeleton) and the Toaster (title-only toasts as the common case, plus a title+description variant). Signed-off-by: Émile Ré <emile@probo.com>
The skeleton frame carries the dialog's shadow-6 elevation, which only reads correctly against the dimmed overlay. Render the story over a simulated backdrop so the preview matches how the dialog appears. Signed-off-by: Émile Ré <emile@probo.com>
The form and its Relay operation were named after the Figma "Login Form" layer, but the rest of the feature speaks "sign in" (SignInDialog, auth.signIn.*, the visible copy). Align the name so the dialog and its form share one prefix. Signed-off-by: Émile Ré <emile@probo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds a modal sign-in flow (magic link + OIDC) to the compliance portal and gates “Get Access” behind authentication. Also adds
DialogandToasterinpackages/ui, wires the toast host, new auth routes, and renamesLoginFormtoSignInFormfor consistency.Other
+1242-10SignInForm, OIDC buttons, magic-link) andSignInDialogProvider; wire TopBar “Get Access” to open it.useResumeAccessRequest; handleFULL_NAME_REQUIREDand NDA errors; show toasts.getSafeContinueUrl,buildRequestAllContinueUrl) to prevent off-site redirects.AuthLayout.<Toaster />) and add i18n strings inen-USandfr-FR.Package: ui
+760-0Dialogprimitives: root, popup, header/body/footer, title/description, trigger/close, skeleton, and Tailwind variants.Toasterwith types, icons, viewport, and theme variants.DialogandToaster(controlled dialog and skeleton).Written for commit a2cb17f. Summary will update on new commits.