Fix n8n ProboTrigger node package review issues#1489
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- Log delete failures in deleteSubscription instead of swallowing them - Correct codex node prefix to @probo/n8n-nodes-probo.proboTrigger - Replace unsupported codex categories with Development and Utility Signed-off-by: Sacha Al Himdani <sacha@probo.com>
SachaProbo
force-pushed
the
SachaProbo/fix-n8n-node-review
branch
from
9b0ff01 to
f14d811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes
n8nProboTrigger node review items. Updates codex metadata and adds clear logging when webhook subscription deletion fails.Package: n8n-node
+7-3@probo/n8n-nodes-probo.proboTrigger.Written for commit f14d811. Summary will update on new commits.