perf: add API for updating attachments#157
Open
jpnurmi wants to merge 17 commits into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-ipz
branch
from
July 10, 2026 06:41
b34cefd to
919800c
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-ipz
branch
from
July 10, 2026 11:53
9dfb02b to
16981c9
Compare
Allow clients to send replacement attachment contents to the handler with variable-length IPC messages. The handler writes the updated bytes to the attachment path while keeping attachment registration unchanged. Co-Authored-By: OpenAI Codex <noreply@openai.com>
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-ipz
branch
from
July 21, 2026 16:15
16981c9 to
b39aaef
Compare
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-ipz
branch
from
July 23, 2026 11:53
abfe568 to
4774df9
Compare
| // append would make the client block on the work this API is meant to avoid. | ||
| WriteResponse(service_context); | ||
| service_context.delegate()->ExceptionHandlerServerAttachmentAppended( | ||
| attachment, payload); |
There was a problem hiding this comment.
Pipe held during attachment I/O
High Severity
HandleWriteAttachment and HandleAppendAttachment perform disk I/O before ServiceClientConnection returns, so DisconnectNamedPipe is delayed until the write finishes. With only kPipeInstances (2) listeners, a large attachment update can monopolize a pipe thread and stall other IPC, including registrations and crash-related messages.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 4774df9. Configure here.
jpnurmi
force-pushed
the
jpnurmi/feat/crashpad-ipz
branch
from
July 23, 2026 11:58
4774df9 to
fca5966
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fde1cf5. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve attachment (
__sentry-eventand__sentry-breadcrumbN) update performance on Windows by offloading write/append disk I/O to the crash handler process over IPC.The client side intentionally only waits until the handler accepts the IPC payload, not until the file write completes. For the sake of simplicity, macOS and Linux keep direct file writes behind the same
CrashpadClientAPI because disk I/O is already cheap enough.Required for (see also for concrete numbers):