Make room for user emails#450
Closed
HazAT wants to merge 1 commit into
Closed
Conversation
Add a nullable slack_email column to the users table, plus the corresponding entity property and email validation rule. The column is nullable because email is only available from Slack's users.info API when the app has the users:read.email OAuth scope, and existing rows need a backfill. Population happens in a follow-up change to keep the schema migration independently deployable. slack_email is added to the entity's _hidden list so it does not leak into the JSON output of existing endpoints that serialize user entities (leaderboard, user list, profile). Exposing it deliberately where needed is a follow-up change.
Member
Author
|
Folded into #452 — one PR for the whole email story. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only know people by their Slack ID, which means nothing to any other system. First step to fixing that: give users an email field. (1/3 — filling it and exposing it come next.) 🥔