-
Notifications
You must be signed in to change notification settings - Fork 38
feat(workspaces): Add switchable repository workspaces #1420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sentry-junior
wants to merge
28
commits into
main
Choose a base branch
from
feat/workspace-mvp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
c991260
feat(workspaces): Add switchable repository workspaces
sentry-junior[bot] 264fe17
test(workspaces): Account for workspace migration
sentry-junior[bot] 5083e84
fix(workspaces): Harden switch lifecycle and checkout paths
sentry-junior[bot] 5873e56
fix(workspaces): Clear failed switch state
sentry-junior[bot] a191959
fix(workspaces): Persist null sandbox clear on failed switch
sentry-junior[bot] 051b11a
perf(workspaces): Extend base snapshots for workspace builds
sentry-junior[bot] f415f9c
fix(workspaces): Tighten snapshot cache invariants
sentry-junior[bot] fab7711
merge: Bring main into workspace MVP branch
sentry-junior[bot] b9f427a
fix(workspaces): Keep durable ref on same-recipe switch
sentry-junior[bot] 58d72b8
test(workspaces): Account for workspace migration after main merge
sentry-junior[bot] 67a5b13
chore(workspaces): Drop unrelated 0025 snapshot formatting
sentry-junior[bot] f46ac4c
fix(workspaces): Start keepalive after workspace switch
sentry-junior[bot] 63fef9a
fix(workspaces): Check cancellation before switch
sentry-junior[bot] 2e155b6
fix(workspaces): Stabilize workspace repo ordering
sentry-junior[bot] b35e86b
fix(sandbox): Stop leaked replacement on failed workspace switch
sentry-junior[bot] 8cb0df1
fix(sandbox): Preserve workspace boot failure
sentry-junior[bot] 62df27a
fix(sandbox): Keep restored sandbox on prepare failure
sentry-junior[bot] 6814e5f
fix(sandbox): Stabilize workspace switch and profile hashing
sentry-junior[bot] b6b568b
fix(sandbox): Stop late in-flight sandbox on workspace switch
sentry-junior[bot] affdcdf
fix(sandbox): Clear stale hint after late in-flight stop
sentry-junior[bot] 724d065
fix(sandbox): Require toThrow message in workspace switch test
sentry-junior[bot] 6abad33
Merge origin/main into feat/workspace-mvp
sentry-junior[bot] ed4825d
fix(workspaces): Reject reserved sandbox checkout paths
sentry-junior[bot] 2281602
fix(sandbox): Restore prior sandbox on mid-switch cancel
sentry-junior[bot] 465241b
Merge remote-tracking branch 'origin/main' into feat/workspace-mvp
sentry-junior[bot] 7c65823
fix(sandbox): Keep durable workspace when recipe is missing
sentry-junior[bot] 54065d2
fix(sandbox): Scope missing workspace profile fallback
sentry-junior[bot] 90d1036
fix(sandbox): Abort workspace setup scripts on cancel
sentry-junior[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| /** Sandbox root directories reserved for Junior runtime material. */ | ||
| export const RESERVED_SANDBOX_DIRECTORIES = new Set([ | ||
| ".junior", | ||
| "data", | ||
| "skills", | ||
| ]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| CREATE TABLE "junior_workspace_repos" ( | ||
| "workspace_id" text NOT NULL, | ||
| "provider" text NOT NULL, | ||
| "repo" text NOT NULL, | ||
| "checkout_path" text NOT NULL, | ||
| "is_primary" boolean DEFAULT false NOT NULL, | ||
| CONSTRAINT "junior_workspace_repos_workspace_id_provider_repo_pk" PRIMARY KEY("workspace_id","provider","repo") | ||
| ); | ||
| --> statement-breakpoint | ||
| CREATE TABLE "junior_workspaces" ( | ||
| "id" text PRIMARY KEY NOT NULL, | ||
| "name" text NOT NULL, | ||
| "setup_script" text DEFAULT '' NOT NULL, | ||
| "created_at" timestamp with time zone NOT NULL, | ||
| "updated_at" timestamp with time zone NOT NULL | ||
| ); | ||
| --> statement-breakpoint | ||
| ALTER TABLE "junior_workspace_repos" ADD CONSTRAINT "junior_workspace_repos_workspace_id_junior_workspaces_id_fk" FOREIGN KEY ("workspace_id") REFERENCES "public"."junior_workspaces"("id") ON DELETE cascade ON UPDATE no action;--> statement-breakpoint | ||
| CREATE UNIQUE INDEX "junior_workspace_repos_checkout_path_idx" ON "junior_workspace_repos" USING btree ("workspace_id","checkout_path");--> statement-breakpoint | ||
| CREATE UNIQUE INDEX "junior_workspace_repos_primary_idx" ON "junior_workspace_repos" USING btree ("workspace_id") WHERE "junior_workspace_repos"."is_primary";--> statement-breakpoint | ||
| CREATE UNIQUE INDEX "junior_workspaces_name_idx" ON "junior_workspaces" USING btree ("name"); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.