feat(attachments): Emit and render delivered attachment transcript items - #1506
Open
sentry-junior[bot] wants to merge 4 commits into
Open
feat(attachments): Emit and render delivered attachment transcript items#1506sentry-junior[bot] wants to merge 4 commits into
sentry-junior[bot] wants to merge 4 commits into
Conversation
Add a host-owned attachments_delivered conversation event so successful sendFiles stores become first-class dashboard transcript media instead of tool-output scraping. Project the event through the report API and render inline images or download cards via the existing attachment route. Co-Authored-By: David Cramer <david@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…olicy Move dashboard coverage to the owning semantic render suite, keep emit coverage on the product SQL harness, and drop the oversized pure-projection case that broke the file-length limit. Co-Authored-By: David Cramer <david@sentry.io>
dcramer
marked this pull request as ready for review
August 13, 2026 01:23
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Cache the successful Slack upload before writing attachments_delivered so a later event-store failure cannot cause a duplicate Slack upload on retry. Make the delivery event idempotent and re-record from the cache path.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b8e7090. Configure here.
Cache hits must re-record attachments_delivered with the first toolCallId, not the current one. Otherwise a later call with the same bytes can mint a second transcript delivery that was never sent to Slack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1503.
Successful
sendFilesalready stores conversation-owned attachments and returnsattachment_refs, and the read route can serve bytes. The dashboard still had no first-class transcript surface for those files.This change adds a host-owned
attachments_deliveredconversation event, projects it through the report API, and renders it in the dashboard as media (inline safe images; download cards otherwise) via the existing attachment route.Why this shape
sendFilesspecial-casing in the UIIncluded
sendFilesstore pathNot in this PR
sendFilesRequested by David Cramer.
--
View Junior Session [Sentry]