fix(chat): Keep archive through system noise - #1511
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
Conversation
Auto-unarchive previously fired on every non-preserve event append and on history replacement. Resource events, turn lifecycle, and compaction could restore archived conversations without a human message. Clear archived_at only for human user instructions or human visible user messages. Keep activity clock updates for system noise. Co-Authored-By: Pierre Massat <pierre.massat@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Archived conversations were coming back into the personal feed without a human message.
What failed
Pierre archived all conversations. They stayed hidden, then later all reappeared.
Evidence
#jr-cramerRoot cause
SqlConversationEventStore.appendclearedarchived_aton every non-preserve write. Resource events, turn lifecycle, and other system noise count as normal appends.replaceHistoryalso cleared archive on compaction/handoff.This matches the product intent from #908 (auto-unarchive on activity), but the activity definition was too broad. #1509 already treated resource events as non-user activity for Priority; archive did not.
Fix
user_message+ instruction provenance on slack/local/web) or human visible user messagesVerification
pnpm --filter @sentry/junior exec vitest run tests/component/conversation-storage-sql.test.ts tests/component/plugins/plugin-conversation-events.test.ts(35 passed)Risk
Medium. Conversations with only resource-event traffic will stay archived until a human message. That is intentional.
Already-unarchived rows are not re-archived by this PR.
Requested by PDPM.
--
View Junior Session [Sentry]