feat(acp): add remote ACP prototype - #1559
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dashboard visual evidenceNo matching dashboard scenarios for this diff. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry-junior[bot]](https://avatars.githubusercontent.com/in/2960336?s=60&v=4){kind=small}
There was a problem hiding this comment.
Looks good to merge and iterate on. This delivers the issue's core vertical slice behind an explicit opt-in: authenticated remote HTTP, private Conversation ownership, shared mailbox/worker execution, durable completion, and reconnect/load replay. The integration coverage exercises the important auth, isolation, idempotency, failure, and disconnect paths.
The remaining #1525 items—active Turn cancellation, a real external-client acceptance run, richer updates, and multi-process transport—are clearly documented as promotion gates rather than implied support, so I would not block this prototype on them.
There was a problem hiding this comment.
The cancellation gap from #1525 is addressed now. session/cancel reaches the active agent run, records a durable cancelled Turn, returns the ACP cancelled stop reason, and releases the session for a later prompt. The follow-up also closes the auth-pause/disconnect and late-cancel race windows, with integration coverage for cancellation plus continued use of the session. Looks good to merge and iterate on.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8280e21. Configure here.
| } finally { | ||
| if (args.signal) { | ||
| args.cancellation?.finish(args.conversationId, args.signal); | ||
| } |
There was a problem hiding this comment.
Cancel lost-lease releases live slot
Medium Severity
completeCancelledApiTurn now always finishes the cancellation slot in a finally block, including when persist or lifecycle finalization fails, and the worker maps a later ack TurnInputCommitLostError to lost_lease. That drops the in-process abort slot while mailbox work is still unacked, so a follow-up session/prompt or the lease-owning retry can begin and run the agent on a Turn that was already closed as cancelled.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 8280e21. Configure here.
2 participants
Add an opt-in ACP v1 Streamable HTTP endpoint so external ACP clients can use
Junior through a URL and personal token. The prototype supports initialization,
private session creation, text prompts through the existing API Turn mailbox,
durable assistant updates, and reconnect/load replay.
This stays remote-only. It adds no stdio mode, agent registry, client workspace
bridge, or separate runtime path. ACP reuses Junior's personal-token auth,
Actor and Conversation access, mailbox, worker, event store, and visible Message
projection. The experimental endpoint is off by default and currently supports
one Node process.
The official SDK loopback smoke and integration coverage exercise auth,
ownership, idempotency, failure mapping, disconnect recovery, and replay. A
named Cloudflare tunnel run and direct T3 Code or Zed acceptance remain
promotion gates rather than claimed support in this prototype.
Refs #1525