feat(replay): Remove replay_relay_snuba_publish_disabled_sample_rate

[tobias-wilfert]

While working on the refactor of the process_replay logic we noticed that relay-snuba-publishing-disabled is perpetually set to 100%.

This PR replaces the option with a hard coded true value and removes all the code that is dead due to this change. Specifically produce_replay_event which currently just early returns and ReplayEventKafkaMessage which is only constructed in this function. Furthermore the tests that rely on the option are also modified or removed (if they now test behaviour that is no longer possible).

Follow up:

• Remove support for standalone replay_events in the processor since they are dropped silently in the store anyways.
• Remove the flag on the sentry and options automator side.
• Check if we can remove the topic (seems like it is still being used here: https://github.com/getsentry/sentry/blob/eebed10f27a4e6687957f30a176ee63fe8946c95/src/sentry/replays/usecases/events.py#L58-L61)

[Dav1dde]

I think we can then also remove the ReplayEvents topic (and follow that up with an infra change to unconfigure the topic)

[tobias-wilfert]

I think for the time that we remove it here but not yet in the infra this will error here:

relay/relay/src/setup.rs

Line 50 in 88085ca

|| relay_log::error!("unused topic assignment '{name}'"),

hope that does not become too spamy.

[Dav1dde]

Yeah that should happen and it's fine, this is the safest way to do it. Remove from code before removing from infra (e.g. to allow for rollbacks). In this case we could do something else considering the topic hasn't been used in a long time, but better to do it the 'right ' way.

We could lower that message from error to warn though. It's error because we didn't used to pipe warnings into Sentry.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

[Dav1dde]

Yeah that should happen and it's fine, this is the safest way to do it. Remove from code before removing from infra (e.g. to allow for rollbacks). In this case we could do something else considering the topic hasn't been used in a long time, but better to do it the 'right ' way.

We could lower that message from error to warn though. It's error because we didn't used to pipe warnings into Sentry.

[jjbayer]

Might benefit from an "internal" changelog because it will change behavior in self-hosted.