Skip to content

chore: bump socket-firewall chart and image versions #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeffreyhung merged 1 commit into from
Aug 3, 2026
Merged

chore: bump socket-firewall chart and image versions #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions terraform/terraform.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ node_max_count = 3
firewall_domain = "sfw.security.sentry.io."

replica_count = 2
helm_chart_version = "0.9.0"
firewall_image_tag = "2.0.10"
helm_chart_version = "0.11.1"

@sentry sentry Bot Aug 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading the socket-firewall Helm chart from 0.9.0 to 0.11.1 may cause silent misconfiguration, as Helm ignores unknown keys and breaking changes in pre-1.0 charts are common.
Severity: HIGH

Suggested Fix

Before merging, manually compare the values.yaml from the Helm chart versions 0.9.0 and 0.11.1 to verify that all keys used in terraform/helm.tf are still valid. Pay special attention to initContainers, redis, and extraConfig. After verification, apply the change in a staging environment and test the features controlled by these configurations to ensure they behave as expected.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: terraform/terraform.tfvars#L16

Potential issue: The upgrade of the `socket-firewall` Helm chart from version `0.9.0` to
`0.11.1` skips a minor version. Since Helm silently ignores unknown configuration keys,
any breaking changes in the chart's `values.yaml` (e.g., renamed or removed keys)
between these versions will not be caught by `terraform plan`. This could lead to
critical features like the Redis-backed cache, TLS certificate generation with specific
UIDs, or the `extraConfig.resilience.circuit_breaker` being silently disabled. The
application might deploy successfully but fail under specific production loads when
these misconfigured features are required.

Also affects:

  • terraform/helm.tf

Did we get this right? 👍 / 👎 to inform future reviews.

firewall_image_tag = "2.0.14"
Loading