Skip to content

chore: bump socket-firewall chart and image versions #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jeffreyhung merged 1 commit into from
Jul 7, 2026
Merged

chore: bump socket-firewall chart and image versions #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions terraform/terraform.tfvars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ node_max_count = 3
firewall_domain = "sfw.security.sentry.io."

replica_count = 2
helm_chart_version = "0.4.1"
firewall_image_tag = "1.1.345"
helm_chart_version = "0.6.0"
firewall_image_tag = "2.0.4"

@sentry sentry Bot Jul 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The major version bump of the firewall image to 2.x may be incompatible with hardcoded configuration values, such as the API token environment variable name.
Severity: HIGH

Suggested Fix

Review the release notes for the firewall image version 2.0.4 to identify any breaking changes related to configuration. Update any hardcoded values, such as the environment variable name for the API token in terraform/helm.tf, to match the requirements of the new version.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: terraform/terraform.tfvars#L17

Potential issue: The firewall image is being upgraded from version 1.1.345 to 2.0.4. A
major version bump from 1.x to 2.x often introduces breaking changes. The current
configuration in `terraform/helm.tf` hardcodes values like `socket.existingSecretKey =
"SOCKET_SECURITY_API_TOKEN"`. If the new 2.x image expects a different environment
variable for the API token, the firewall could fail to authenticate. This might result
in a crash or a fail-open state, which is a security risk for a critical component.

Also affects:

  • terraform/helm.tf

Did we get this right? 👍 / 👎 to inform future reviews.

Loading