Fix: Craft breaking releases - #1074
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
| fetch-depth: 0 | ||
| - name: Create install action from Craft | ||
| run: | | ||
| mkdir -p install |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
This looks like a bug in craft itself. Let me see if I can fix it there first. Sorry for the issue |
antonis
left a comment
There was a problem hiding this comment.
Thank you for looking at this Lucas 🙇 The changes look good and solve the issue. Let's wait for the Craft fix before proceeding with a repo specific fix.
|
New release: |
|
Tried other 2 releases and both worked |
antonis
left a comment
There was a problem hiding this comment.
Thank you @lucas-zimerman 🙇
LGTM 🎉
Craft wasn't finding the action.yml from craft, so I added a copy of it.
The previous error was the following:
by copying action.yml into the repository, we fix the issue.
I also removed some simple JS dependencies so we don't require installing any node packages during release.
#skip-changelog