Skip to content

Fix: Craft breaking releases - #1074

Merged
lucas-zimerman merged 6 commits into
mainfrom
lz/fix-craft
Jan 13, 2026
Merged

Fix: Craft breaking releases#1074
lucas-zimerman merged 6 commits into
mainfrom
lz/fix-craft

Conversation

@lucas-zimerman

@lucas-zimerman lucas-zimerman commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator

Craft wasn't finding the action.yml from craft, so I added a copy of it.
The previous error was the following:


Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under '/home/runner/work/sentry-capacitor/sentry-capacitor/install'. Did you forget to run actions/checkout before running your local action?

by copying action.yml into the repository, we fix the issue.

I also removed some simple JS dependencies so we don't require installing any node packages during release.

#skip-changelog

@github-actions

github-actions Bot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@lucas-zimerman lucas-zimerman changed the title Lz/fix craft Fix: Craft not working with relase files Jan 12, 2026
@lucas-zimerman

Copy link
Copy Markdown
Collaborator Author

@lucas-zimerman
lucas-zimerman marked this pull request as ready for review January 12, 2026 16:27
@lucas-zimerman
lucas-zimerman requested review from BYK and antonis January 12, 2026 16:27
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
fetch-depth: 0
- name: Create install action from Craft
run: |
mkdir -p install

This comment was marked as outdated.

@BYK

BYK commented Jan 12, 2026

Copy link
Copy Markdown
Member

This looks like a bug in craft itself. Let me see if I can fix it there first. Sorry for the issue

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking at this Lucas 🙇 The changes look good and solve the issue. Let's wait for the Craft fix before proceeding with a repo specific fix.

Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml Outdated
@lucas-zimerman

Copy link
Copy Markdown
Collaborator Author

@lucas-zimerman

Copy link
Copy Markdown
Collaborator Author

Tried other 2 releases and both worked

@antonis antonis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lucas-zimerman 🙇
LGTM 🎉

@lucas-zimerman
lucas-zimerman merged commit f7b66fa into main Jan 13, 2026
21 of 23 checks passed
@lucas-zimerman
lucas-zimerman deleted the lz/fix-craft branch January 13, 2026 11:15
@lucas-zimerman lucas-zimerman changed the title Fix: Craft not working with relase files Fix: Craft breaking releases Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants