test: Use cargo_bin macro for binary discovery in tests #3107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
changed the title
szokeasaurusrex
added
the
skip-changelog
Use the `cargo_bin!` macro from assert_cmd to locate the sentry-cli binary. This reads the `CARGO_BIN_EXE_sentry-cli` environment variable set by Cargo at compile time, making tests work regardless of custom `build-dir` settings in cargo config. Previously, both `Command::cargo_bin()` and trycmd's internal binary discovery would fail when a custom build directory was configured, causing tests to either error or silently pass as "ignored". Co-Authored-By: Claude <noreply@anthropic.com>
szokeasaurusrex
force-pushed
the
szokeasaurusrex/test-fix
branch
from
0b68411 to
53f3fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
cargo_bin!macro from assert_cmd to locate the sentry-cli binary via Cargo's environment variables rather than filesystem discovery. This allows tests to work with custombuild-dirconfigurations like:Custom build directories help share dependencies across projects and reduce disk usage. See Cargo build directory documentation.