Skip to content

feat(attributes): Add server_name (deprecated) and sentry.metric.source#477

Open
cleptric wants to merge 6 commits into
mainfrom
feat/add-server-address-deprecated
Open

feat(attributes): Add server_name (deprecated) and sentry.metric.source#477
cleptric wants to merge 6 commits into
mainfrom
feat/add-server-address-deprecated

Conversation

@cleptric

@cleptric cleptric commented Jul 9, 2026

Copy link
Copy Markdown
Member

Add server_name as a deprecated attribute pointing to server.address as the OTel-aligned replacement, following the same pattern as other recent deprecations (faas.idcloud.resource_id, faas.executionfaas.invocation_id). The server.address alias list is updated to include server_name.

Also adds the new sentry.metric.source attribute.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add server_name (deprecated) and sentry.metric.source by cleptric in #477
  • Add sentry.metric.source by klochek in #476
  • Add faas.id (deprecated) in favor of cloud.resource_id by andreiborza in #475
  • Add faas.execution (deprecated) in favor of faas.invocation_id by andreiborza in #473
  • Add messaging attributes by s1gr1d in #469
  • Add url.same_origin (deprecated) and http.request.same_origin (replacement) attributes by Lms24 in #456
  • Add db.response.status_code by s1gr1d in #462

Other

  • (ai) Add granular cost attributes for cache and reasoning by vgrozdanic in #461
  • (js) Add _BASE attribute key exports for dynamic attribute keys by Lms24 in #471

Internal Changes 🔧

  • (ci) Stop inheriting secrets for changelog-preview by tobias-wilfert in #463

🤖 This preview updates automatically when you update the PR.

…er.address`

Add server_address as a deprecated attribute pointing to server.address
as the correct OTel-aligned replacement. Update server.address aliases
to include server_address for symmetry.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cleptric cleptric force-pushed the feat/add-server-address-deprecated branch from 63d97a3 to 0e89b2f Compare July 9, 2026 20:51
cleptric and others added 3 commits July 9, 2026 23:22
The generated attributes file was out of sync with the model,
causing CI to fail on the uncommitted-changes check.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cleptric cleptric marked this pull request as ready for review July 9, 2026 21:30
@cleptric cleptric requested review from a team, Lms24, mjq and nsdeschenes as code owners July 9, 2026 21:30

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f4ab733. Configure here.

Comment thread model/attributes/server_address.json Outdated
Add `server_address` to the alias lists of `http.server_name`,
`net.host.name`, and `http.host`, and add those three to the alias
list of `server_address`. This ensures every member of the alias
group references every other member, matching the pattern used by
other deprecated attributes like `faas.execution`.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cleptric cleptric changed the title feat(attributes): Add server_address (deprecated) in favor of server.address feat(attributes): Add server_name (deprecated) and sentry.metric.source Jul 10, 2026
…ted)

The deprecated attribute should be server_name, not server_address.
Update all alias references across the server.address alias group.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cleptric cleptric force-pushed the feat/add-server-address-deprecated branch from ddd7d3a to 237ab20 Compare July 10, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants