feat(attributes): Add messaging, rpc and gen_ai attributes#482
Merged
Conversation
andreiborza
requested review from
a team,
Lms24,
cleptric,
mjq and
nsdeschenes
as code owners
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
This was referenced Jul 10, 2026
andreiborza
force-pushed
the
ab/faas-invoked-attributes
branch
from
fc8c03f to
acfd7bb
Compare
andreiborza
force-pushed
the
ab/otel-semconv-attributes
branch
from
3615aad to
6814011
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/otel-semconv-attributes
branch
from
6814011 to
3018afd
Compare
alexander-alderman-webb
approved these changes
Jul 10, 2026
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
Contributor
There was a problem hiding this comment.
looks good to me for the gen_ai attribute
Lms24
reviewed
Jul 10, 2026
| @@ -0,0 +1,18 @@ | |||
| { | |||
| "key": "rpc.system", | |||
Member
There was a problem hiding this comment.
can we deprecate this in favour of rpc.system.name? It's what OTel does: https://opentelemetry.io/docs/specs/semconv/registry/attributes/rpc/#rpc-system
Member
Author
There was a problem hiding this comment.
ah yea, good catch. I think they just haven't done that in the aws instrumentation yet, but will do.
Lms24
approved these changes
Jul 10, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds generic OTel semantic-convention attributes:
gen_ai.request.stop_sequences,rpc.system, andmessaging.destination(deprecated in favor ofmessaging.destination.name).OTel sem conv sources used: