test: Build e2e native modules with clang on Linux - #1408
Closed
timfish wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Closing in favour of a fix in @sentry/node-native-stacktrace itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
E2E Tests (ubuntu-22.04, 43.2.0, *)jobs fail (see #1398) becauseelectron-rebuildcannot compile@sentry/node-native-stacktraceagainst the Electron 43 headers with GCC.Electron 43 ships V8 15.0, where
v8::String::Valueis now marked with a class-levelV8_DEPRECATED(...)(v8-primitive.h:655):node-gyp compiles addons with
-DV8_DEPRECATION_WARNINGS=1, so this expands toclass [[deprecated("…")]] __attribute__((visibility("default"))) Value— a C++11 attribute mixed with a GNU attribute in a class head. GCC ≤ 12 cannot parse this construct (in either attribute order); GCC 13+ and clang accept it. The ubuntu-22.04 runners default to GCC 11, hence Linux-only failures.This sets
CC/CXXto clang (preinstalled on the runners) for the e2e job. Switching the runner to ubuntu-24.04 (GCC 13.3) would also fix the compile, but 24.04 breaks the native crash tests (#1332).A follow-up fix in
@sentry/node-native-stacktrace(e.g. strippingV8_DEPRECATION_WARNINGSinbinding.gyp) is needed so end users building the ANR native module against Electron ≥ 43 with stock GCC ≤ 12 (Ubuntu 22.04 / Debian 12) aren't hit by the same failure.