Skip to content

feat(logging): skill for instrumenting logging#222

Merged
bcoe merged 5 commits into
mainfrom
logging-instrumentation-skill
Jul 8, 2026
Merged

feat(logging): skill for instrumenting logging#222
bcoe merged 5 commits into
mainfrom
logging-instrumentation-skill

Conversation

@bcoe

@bcoe bcoe commented Jun 27, 2026

Copy link
Copy Markdown
Member

A pass at a skill that provides recommendations for instrumenting sentry logging.

Tested against:

Implementation note: For repositories containing multiple languages or SDKs, the skill delegates language-specific instrumentation to the corresponding SDK skills.

Skill that enables logging and suggests some initial log messages
@bcoe
bcoe force-pushed the logging-instrumentation-skill branch from b7f7bd3 to ae27d7a Compare July 7, 2026 18:29
@bcoe
bcoe force-pushed the logging-instrumentation-skill branch from ae27d7a to 8808771 Compare July 7, 2026 18:44
@bcoe
bcoe marked this pull request as ready for review July 7, 2026 18:46
Comment thread skills/sentry-instrument-logging/SKILL.md Outdated
Comment thread skills/sentry-instrument-logging/SKILL.md Outdated
Comment thread skills/sentry-instrument-logging/SKILL.md
Comment thread skills/sentry-instrument-logging/SKILL.md

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 03142fe. Configure here.

say so explicitly rather than implying it passed.

4. **Apply a high-value log validation check.** Review every added or modified log line
and remove or revise any log that does not pass this check:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation after verified status

Medium Severity

Per-app step 3e marks apps verified after tests, but step 4 can remove or rewrite logs afterward with no second verification pass, so inventory status can claim verified while instrumentation no longer matches what was checked.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 03142fe. Configure here.

Comment on lines +10 to +11
# Instrument Sentry Logging

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The new skill sentry-instrument-logging/SKILL.md is missing the required breadcrumb navigation link, which violates documented project conventions.
Severity: LOW

Suggested Fix

Add the required breadcrumb link as the first line in the body of skills/sentry-instrument-logging/SKILL.md, after the frontmatter. The line should be: > [All Skills](../../SKILL_TREE.md) > [Feature Setup](../sentry-feature-setup/SKILL.md) > Instrument Sentry Logging.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: skills/sentry-instrument-logging/SKILL.md#L10-L11

Potential issue: The new skill file `skills/sentry-instrument-logging/SKILL.md` is
missing a breadcrumb navigation link, which is a documented requirement in `AGENTS.md`.
This link is present in all other similar skill files and is used for navigation within
the skill hierarchy. While its absence does not cause a crash or functional failure of
the skill itself, it violates the project's structural conventions and may impair
navigation for tools or users relying on this metadata.

@bcoe
bcoe merged commit 606e2bc into main Jul 8, 2026
18 checks passed
@bcoe
bcoe deleted the logging-instrumentation-skill branch July 8, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants