Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/references/sdks/react/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -359,13 +359,18 @@ Fine-grained control over what data the SDK collects. Replaces the simple `sendD
| `cookies` | `boolean \| { allow: string[] } \| { deny: string[] }` | `true` | Cookie collection and filtering; `true` = all cookies (sensitive keys filtered) |
| `httpHeaders.request` | `boolean \| { allow: string[] } \| { deny: string[] }` | `true` | HTTP request header collection |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Documentation for dataCollection options was updated for the React SDK but not for other affected JavaScript SDKs, creating an inconsistency.
Severity: LOW

Suggested Fix

Update the dataCollection documentation in all relevant JavaScript SDK files (e.g., browser/index.md, node/index.md, svelte/index.md) to replace queryParams with urlQueryParams and add the new graphQL and databaseQueryData options, mirroring the changes made to the React SDK documentation.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: src/references/sdks/react/index.md#L360

Potential issue: The pull request updates the documentation for the React SDK to reflect
a change from `queryParams` to `urlQueryParams` and adds new `graphQL` and
`databaseQueryData` options. This change originates in `@sentry/core`, which suggests it
should apply to all JavaScript SDKs. However, the documentation for other SDKs, such as
Browser, Node, Svelte, NestJS, NextJS, and TanStack Start, was not updated. This creates
an inconsistency where developers using other SDKs are shown outdated and incorrect
configuration options, potentially leading to confusion and misconfiguration.

Also affects:

  • src/references/sdks/svelte/index.md
  • src/references/sdks/browser/index.md
  • src/references/sdks/node/index.md
  • src/references/sdks/nestjs/index.md
  • src/references/sdks/tanstack-start/index.md
  • src/references/sdks/nextjs/index.md

Did we get this right? 👍 / 👎 to inform future reviews.

| `httpHeaders.response` | `boolean \| { allow: string[] } \| { deny: string[] }` | `true` | HTTP response header collection |
| `queryParams` | `boolean \| { allow: string[] } \| { deny: string[] }` | `true` | Query parameter collection and filtering |
| `urlQueryParams` | `boolean \| { allow: string[] } \| { deny: string[] }` | `true` | Query parameter collection and filtering (SDK ≥10.67.0; replaces deprecated `queryParams`) |
| `httpBodies` | `HttpBodyCollectionTarget[]` | `["incomingRequest", "outgoingRequest", "incomingResponse", "outgoingResponse"]` | Collect request/response bodies; options: `'incomingRequest'`, `'outgoingRequest'`, `'incomingResponse'`, `'outgoingResponse'` |
| `graphQL.document` | `boolean` | `true` | Attach the GraphQL document (query/mutation source text) — requires a GraphQL integration enabled (SDK ≥10.66.0) |
| `graphQL.variables` | `boolean` | `true` | Attach GraphQL operation variables — requires a GraphQL integration enabled (SDK ≥10.66.0) |
| `databaseQueryData` | `boolean` | `true` | Collect DB query parameters, inline literal values, mutation/request bodies, and returned result data (SDK ≥10.66.0) |
| `genAI.inputs` | `boolean` | `true` | Record AI model inputs (for AI monitoring) |
| `genAI.outputs` | `boolean` | `true` | Record AI model outputs (for AI monitoring) |
| `stackFrameVariables` | `boolean` | `true` | Capture local variable values in stack frames |
| `frameContextLines` | `number` | `5` | Source code context lines around stack frames |

> **Deprecated:** `queryParams` still works but is deprecated in favor of `urlQueryParams` (same shape and default).

**Example:** Allow only specific cookies and headers:

```typescript
Expand Down