[skill-drift] update(sentry-browser-sdk): document urlQueryParams rename and new graphQL/databaseQueryData/stackFrameVariables options - #300
Open
github-actions[bot] wants to merge 1 commit into
Conversation
…ame and new graphQL/databaseQueryData/stackFrameVariables options Automated drift-fix run. Co-Authored-By: Claude (claude-sonnet-5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Auto-generated from external SDK content. Review all links and code suggestions before acting on them.
Warning
Auto-generated from external SDK content. Review all links and code suggestions before acting on them.
What changed upstream
@sentry/browser(via@sentry/core) shipped several related changes to thedataCollectioninit option, released in10.66.0/10.67.0/10.68.0:queryParamsrenamed tourlQueryParams(#22217, released 10.67.0).queryParamsstill works but is now marked@deprecatedin favor of the new name; same shape (boolean | { allow: string[] } | { deny: string[] }) and default (true).dataCollection.graphQLoption (#22221, released 10.66.0) —{ document?: boolean; variables?: boolean }, both defaulttrue. Controls whether GraphQL document text and operation variables are attached when a GraphQL integration is enabled. Does not add instrumentation on its own.dataCollection.databaseQueryDataoption (#22219, released 10.66.0) —boolean, defaulttrue. Controls collection of DB query parameters, inline literal values, mutation/request bodies, and returned result data. Sanitizeddb.query.textand structural metadata are always collected regardless of this flag.stackFrameVariablesnow accepts aCollectBehavior, not just a boolean (#22526, released 10.68.0).{ allow: string[] } | { deny: string[] }filters captured local variables by name. Note: filtering matches names after bundling/minification, so source-level variable names may not match at runtime.Verified directly against
packages/core/src/types/datacollection.tsat the10.68.0release tag.What was out of date
src/references/sdks/browser/index.md'sdataCollectionOptions table still listed only the deprecatedqueryParamsfield, had no rows forgraphQLordatabaseQueryData, and documentedstackFrameVariablesas a plain boolean.Fix
Updated the table in
src/references/sdks/browser/index.md:queryParamsrow withurlQueryParams(noting the deprecation and min version) and added a deprecation callout below the table.graphQLanddatabaseQueryDatarows with defaults and minimum SDK versions.stackFrameVariablesrow to document the newCollectBehaviorfiltering shape and the bundling/minification caveat.dataCollectionexample to useurlQueryParamsinstead of the deprecatedqueryParams.No other file in the
browserreference tree mentionsqueryParams/urlQueryParams/graphQL/databaseQueryData/stackFrameVariables, so no other edits were needed.Other PRs reviewed but not actioned
feat(core)!: Default attachStacktrace to true— real breaking change to a documented option (attachStackTracedefault flips fromfalsetotrue), but merge commit5ff9fd0is not yet contained in the latest release tag10.68.0(compare status:diverged) — unreleased, so left for a future run once it ships.feat(opentelemetry)!: Remove SentrySpanProcessor & SentrySamplerand #22528feat(core)!: Remove kind for spans, move to sentry.kind attribute— internal/OTel-surface changes not exposed through the browser SDK's documented public API.fix(v10/core): Avoid functionToStringIntegration causing infinite recursions— bug fix to a default integration, no documentable behavior change.http.route/url.full/url.pathonhttp.serverspans — server-side (Node/http.server) only, not applicable to@sentry/browser.Note: this is the same underlying
dataCollectiondrift already flagged for@sentry/reactin PR #293 (still open) — that PR explicitly called out browser as needing the analogous fix.Source PRs
queryParamstourlQueryParamsdataCollection.graphQLdataCollection.databaseQueryDatastackFrameVariablesby variable nameSource PRs
queryParamstourlQueryParamsdataCollection.graphQLdataCollection.databaseQueryDatastackFrameVariablesby variable nameattachStacktraceto true