chore: Integrate godot-kaboom library for crash testing#513
chore: Integrate godot-kaboom library for crash testing#513
Conversation
Move the duplicated get_property() function from sentry-cocoa.SConscript and wasm_split.py into site_scons/utils.py, since site_scons is already on the SCons Python path. Co-Authored-By: Claude <noreply@anthropic.com>
The function reads from a file on disk, so read_property() better communicates the I/O intent to callers. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Allows downloading kaboom debug symbols separately from the addon binaries via `scons kaboom_symbols`. Co-Authored-By: Claude <noreply@anthropic.com>
Support wiping the target directory before extraction (clean) and using a custom version marker file (version_file). This enables kaboom_symbols to track its version independently from the main kaboom addon in the same directory. Also bump kaboom to 0.0.1. Co-Authored-By: Claude <noreply@anthropic.com>
Encapsulate the Command + target/source wiring inside the tool so callers just invoke env.FetchGithubRelease() directly. Simplifies the SConstruct kaboom targets. Co-Authored-By: Claude <noreply@anthropic.com>
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
limbonaut
changed the title
limbonaut
changed the title
Refuse to rmtree directories that resolve outside the project root to prevent accidental deletion of unrelated paths. Co-Authored-By: Claude <noreply@anthropic.com>
|
@sentry review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Use maxsplit=1 in read_property() to avoid silently truncating values that contain '=' (e.g., URLs with query parameters, base64 strings). Co-Authored-By: Claude <noreply@anthropic.com>
|
Closed by accident |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
|
Kaboom! 💥 Is this blocked on the repo creation? Would it help to serve the lib from GH releases or from an orphan branch of this repo instead? For example, something similar to sentry-dotnet that has some old retired version of a dependency archived like this: https://github.com/getsentry/sentry-dotnet/releases/tag/1.0.0.0-xamarin-ios |
|
Yes, it's blocked on repo creation. We can bring it up with the team. The idea is to serve the lib from GH releases, so we don't have to store debug symbols in the consuming projects. And since the plan is to use it in sentry projects, it would make sense to adopt it (to reduce security risks). But, alternatively, this code can be vendored inside sentry-godot. We can expose a hidden property on |
4 participants
Integrate godot-kaboom - a GDExtension library that triggers controlled native crashes for testing Sentry's crash reporting. The repo can be adopted in getsentry.
Adds a general-purpose
FetchGithubReleaseSCons tool that downloads zip assets from GitHub releases with version caching and prefix stripping. Used to fetch the pre-built kaboom addon viascons kaboomand its debug symbols viascons kaboom_symbols.Also extracts the shared
read_property()utility from sentry-cocoa's SConscript intosite_scons/utils.pyfor reuse across tools.Removes the internal
SentrySDK._demo_helper_crash_app()method - crash triggering is now fully handled by the kaboom library. Both the demo project and CLI integration tests (crash-capturecommand) use Kaboom. CI fetches the addon automatically via theprepare-testingaction.