fix(core): Restore directory processor interrupt flag - #5884
Merged
Conversation
Restore the interrupt status when the inter-envelope processing delay is interrupted so callers can observe the interruption after directory processing returns. Add regression coverage for the interrupted delay path. Fixes JAVA-666 Co-Authored-By: OpenCode <noreply@opencode.ai>
0xadam-brown
force-pushed
the
fix/directory-processor-thread-interrupt
branch
from
August 3, 2026 14:03
07a909c to
12a780d
Compare
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 455eb6e | 341.51 ms | 428.96 ms | 87.45 ms |
| d15471f | 343.13 ms | 361.47 ms | 18.34 ms |
| b193867 | 331.08 ms | 397.06 ms | 65.98 ms |
| 5b1a06b | 315.40 ms | 353.33 ms | 37.94 ms |
| 62b579c | 312.88 ms | 361.57 ms | 48.70 ms |
| 85d7417 | 347.21 ms | 394.35 ms | 47.15 ms |
| 6dff1c9 | 298.04 ms | 327.43 ms | 29.39 ms |
| 5b1a06b | 310.56 ms | 362.79 ms | 52.22 ms |
| ee747ae | 386.94 ms | 431.43 ms | 44.49 ms |
| 462dea2 | 322.40 ms | 370.06 ms | 47.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 455eb6e | 0 B | 0 B | 0 B |
| d15471f | 1.58 MiB | 2.13 MiB | 559.54 KiB |
| b193867 | 1.58 MiB | 2.19 MiB | 620.00 KiB |
| 5b1a06b | 0 B | 0 B | 0 B |
| 62b579c | 0 B | 0 B | 0 B |
| 85d7417 | 1.58 MiB | 2.10 MiB | 533.44 KiB |
| 6dff1c9 | 0 B | 0 B | 0 B |
| 5b1a06b | 0 B | 0 B | 0 B |
| ee747ae | 1.58 MiB | 2.10 MiB | 530.95 KiB |
| 462dea2 | 0 B | 0 B | 0 B |
0xadam-brown
added
the
sanity-check
0xadam-brown
marked this pull request as ready for review
August 3, 2026 14:12
0xadam-brown
requested review from
adinauer,
markushi,
romtsn and
runningcode
as code owners
August 3, 2026 14:12
runningcode
approved these changes
Aug 5, 2026
runningcode
left a comment
runningcode
left a comment
Contributor
There was a problem hiding this comment.
Nice find and fix! I wonder if there are other places with the same issue because we catch Throwable too broadly!
Handle thread interruption as its own control path in DirectoryProcessor. Restore the interrupt flag and log the interruption at INFO so shutdown or cancellation does not look like an application error. Co-Authored-By: OpenCode <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Restores thread interrupt status when the inter-envelope processing delay is interrupted so callers can observe the status after directory processing returns.
💡 Motivation and Context
Fixes JAVA-666
💚 How did you test it?
Via a new regression test
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps