PoC: Rollup Plugin without Unplugin #858
Draft
+241
−92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this stashed and thought I may as well open a PR so this code doesn't die on my laptop!
Should we do this?
Personally I think we should migrate away from unplugin because:
This PR drops using Unplugin for Rollup and instead just exports a single Rollup plugin that handles everything. For Vite we can just re-export the Rollup plugin with an additional wrapper.
Downsides?
If we add support for hook filters (#749), we would actually want the transforms to be contained in their own plugins because they would each need different regex filters for the best performance.