-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(bun): Add initWithoutDefaultIntegrations and getDefaultIntegrationsWithoutPerformance #22036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JPeer264
merged 4 commits into
getsentry:develop
from
PeterWadie:feat/bun-init-without-default-integrations
Jul 15, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2d7b96f
feat(bun): Add initWithoutDefaultIntegrations and getDefaultIntegrati…
PeterWadie 95689aa
ref(bun): Match @sentry/node nullish handling of defaultIntegrations
PeterWadie 790c143
ref(bun): Keep the existing undefined check for defaultIntegrations
PeterWadie 38043bb
Merge branch 'develop' into feat/bun-init-without-default-integrations
PeterWadie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: We should leave this as before, even if it looks cleaner and is technically more correct. The reason for that is that we would check against
nulltoo with the new implementation, while the older one only matches forundefined. I don't think changing the behavior now is good (especially when other SDKs still have this check)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted — kept the
=== undefinedcheck so the null-handling behavior is unchanged (and it stays consistent with@sentry/deno, which uses the same check).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you push it already? It seems that is still the old codeNvm. I was checking the wrong commit 🤷