chore: Unpin Node 22 test matrix from 22.12 - #22447
Merged
Merged
Conversation
Node 22.12.0 (the only 22.12.x release) is the first release with unflagged require(ESM). Under that path the solidstart vite tests trip esbuild's startup invariant ("new TextEncoder().encode("") instanceof Uint8Array" is false), failing the Node 22 unit-test job on every run and blocking all PRs.
Float the 22 line back to the latest 22.x LTS, which the job was green on before it was pinned, and which matches the floating 24/26 entries.
logaretm
changed the title
logaretm
marked this pull request as ready for review
July 21, 2026 16:45
logaretm
requested review from
a team,
JPeer264,
isaacs and
timfish
and removed request for
a team
July 21, 2026 16:45
timfish
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unpins the Node 22 unit-test matrix from
22.12back to the latest22.xLTS.Something about esbuild and Node 22.12 specific version crashes it when used with jsdom which is exercised in solidstart.