feat(deno): add lruMemoizer integration - #22453
Merged
Merged
Conversation
isaacs
requested review from
JPeer264 and
andreiborza
and removed request for
a team
July 21, 2026 18:26
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
2 times, most recently
from
July 21, 2026 19:36
5da649b to
ad82a2a
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 21, 2026 19:49
ad82a2a to
ba29b3a
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 21, 2026 21:43
ba29b3a to
a2c00be
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 22, 2026 00:51
a2c00be to
e758510
Compare
nicohrubec
approved these changes
Jul 22, 2026
JPeer264
approved these changes
Jul 22, 2026
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 22, 2026 14:42
e758510 to
a100fe7
Compare
isaacs
requested review from
chargome,
msonnb and
mydea
and removed request for
a team
July 22, 2026 14:42
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 22, 2026 22:02
a100fe7 to
9d37f38
Compare
Contributor
size-limit report 📦
|
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 23, 2026 14:29
9d37f38 to
cee6ad4
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 23, 2026 18:10
cee6ad4 to
14acde5
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
2 times, most recently
from
July 23, 2026 21:19
1414310 to
62951af
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 23, 2026 22:45
62951af to
f521481
Compare
isaacs
force-pushed
the
isaacs/deno-orchestrion-integrations-lrumemoizer
branch
from
July 23, 2026 22:47
f521481 to
021f09a
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+65
to
+70
| Deno.test('lru-memoizer instrumentation: included in default integrations (Deno 2.8.0+)', () => { | ||
| resetGlobals(); | ||
| const client = init({ dsn: 'https://username@domain/123' }) as DenoClient; | ||
| const names = client.getOptions().integrations.map(i => i.name); | ||
| assert(names.includes('LruMemoizer'), `LruMemoizer should be in defaults, got ${names.join(', ')}`); | ||
| }); |
Contributor
There was a problem hiding this comment.
Bug: The Deno integration test for LruMemoizer will fail on Deno versions older than 2.8.0 because it lacks a version guard before asserting the integration is present.
Severity: LOW
Suggested Fix
Add a version check at the beginning of the test to skip execution on Deno versions older than 2.8.0. Use the existing gte() version helper function, similar to the pattern found in packages/deno/test/deno-http.test.ts, to ensure the test only runs in compatible environments.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/deno-integration-tests/suites/orchestrion-lru-memoizer/test.ts#L65-L70
Potential issue: The integration test for the LruMemoizer unconditionally asserts that
the `LruMemoizer` integration is included in the default integrations. However, the
production code only includes this integration on Deno versions 2.8.0 and newer, guarded
by the `MODULE_REGISTER_HOOKS_SUPPORTED` flag. Although the test title includes "(Deno
2.8.0+)", there is no corresponding version check in the test's implementation. This
will cause the test to fail if run on an older Deno version, for instance, if the CI
configuration is updated to test against a matrix of Deno versions or if a developer
runs it locally.
Also affects:
packages/deno/src/sdk.ts:82~84
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.