feat(core)!: Remove enableTruncation flag and gen_ai text truncation - #22548
Draft
nicohrubec wants to merge 4 commits into
Draft
feat(core)!: Remove enableTruncation flag and gen_ai text truncation#22548nicohrubec wants to merge 4 commits into
enableTruncation flag and gen_ai text truncation#22548nicohrubec wants to merge 4 commits into
Conversation
Removes the `streamGenAiSpans` client option. The behavior it gated (extracting gen_ai spans from transactions into a v2 span envelope container) was already the default and is now unconditional — there is no longer a way to opt out. For static transactions, `extractGenAiSpansFromEvent` always pulls gen_ai spans into a v2 span container. For full span streaming (`traceLifecycle: 'stream'`), the existing `hasSpanStreamingEnabled` guard still short-circuits so spans are not extracted twice. Because gen_ai spans now always take the v2 path (not subject to the transaction payload-size limits that truncation works around), `shouldEnableTruncation` simplifies to `!getClient()`. The `enableTruncation` escape hatch is intentionally left in place for a follow-up. Test suites that set `streamGenAiSpans: false` to assert on `transaction.spans` are migrated to assert on the v2 span container; redundant `streamGenAiSpans: true` config lines are removed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ength` attribute This internal SDK-meta span attribute only ever signaled how many gen_ai input messages existed before truncation dropped some. It carries no meaning for consumers on its own and is being removed ahead of the truncation removal. Text truncation itself is unchanged by this commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Removes the `enableTruncation` integration option and the gen_ai message text-truncation machinery. Now that gen_ai spans always ride the v2 span path (far larger size limits than legacy transactions), the byte-limit cropping and "keep only the last message" reduction is dead weight. Inline media stripping is kept and is now unconditional: previously media was only stripped on the truncation path, so with truncation off inline base64 could leak into span attributes for openai/anthropic/google-genai/ vercel-ai/workers-ai. `getGenAiMessagesJsonString` now always strips media before serializing, keeping all messages. Media-stripping logic is consolidated into `mediaStripping.ts`; `messageTruncation.ts` is deleted. Truncation-specific test scenarios and instruments are removed; image-stripping tests are re-pointed at the default recording instruments, and full span-streaming coverage is kept via non-truncation streaming tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e541815. Configure here.
Contributor
size-limit report 📦
|
The migrated media-stripping test hard-coded `auto.ai.anthropic`, which is `auto.ai.orchestrion.anthropic` under the orchestrion runtime. Gate it on `isOrchestrionEnabled()` like the rest of the suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove genai text truncation:
enableTruncationintegration option and all gen_ai text-truncation logic (messageTruncation.ts); byte-limit cropping and "keep only the last message" are gone now that gen_ai spans always use the v2 span path.mediaStripping.ts.@sentry/coreand@sentry/server-utils.