build(deps): upgrade oxfmt to 0.60 and reformat - #22563
Merged
Merged
Conversation
logaretm
changed the title
Contributor
size-limit report 📦
|
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 23, 2026 16:49
16adca0 to
2b29b4b
Compare
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 23, 2026 17:06
2b29b4b to
85225ae
Compare
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 23, 2026 18:41
85225ae to
72518b7
Compare
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 24, 2026 20:01
72518b7 to
46741af
Compare
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 27, 2026 15:24
46741af to
508fd14
Compare
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 27, 2026 15:50
508fd14 to
c15aa63
Compare
logaretm
marked this pull request as ready for review
July 27, 2026 16:58
logaretm
requested review from
JPeer264,
Lms24,
isaacs,
msonnb,
nicohrubec and
s1gr1d
and removed request for
a team
July 27, 2026 16:58
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 27, 2026 19:57
c15aa63 to
968c086
Compare
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 27, 2026 19:58
968c086 to
cb3e789
Compare
Lms24
reviewed
Jul 28, 2026
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Nice! Formatting changes look good, just had one comment we should resolve prior to merging.
| export function setAttribute< | ||
| // oxlint-disable-next-line typescript-eslint/no-explicit-any | ||
| T extends RawAttribute<T> extends { value: any } | { unit: any } ? AttributeObject : unknown, | ||
| T extends (RawAttribute<T> extends { value: any } | { unit: any } ? AttributeObject : unknown), |
Member
There was a problem hiding this comment.
this I find interesting: I thought formatters tried to avoid unnecessary brackets as much as possible. I have no objections to adding the brackets here but just wondering if you know why it chose to add them. Anyway, just curious not a blocker for this PR
Member
Author
There was a problem hiding this comment.
No idea, when I looked it seemed like this one introduced it oxc-project/oxc#24450 but no reasoning is given.
Comment on lines
+296
to
+301
| async function _getResponseText(response: Response): Promise<string> { | ||
| return response.text(); | ||
| // Force this to be a promise, just to be safe. The extra microtask tick is load-bearing for | ||
| // network-breadcrumb timing (dropping it makes handleNetworkBreadcrumbs serialize before the | ||
| // fetch details are attached). | ||
| // oxlint-disable-next-line typescript/return-await -- see above; the await must stay | ||
| return await response.text(); |
Member
There was a problem hiding this comment.
m: should this be part of this PR? Looks like a bugfix 🤔
Member
Author
There was a problem hiding this comment.
That is a stranded commit that I dropped in the earlier PR, I have no idea why it is here. Thanks for catching this!
Removed this diff.
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 28, 2026 13:57
cb3e789 to
0942642
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0942642. Configure here.
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 28, 2026 14:40
0942642 to
0e43976
Compare
Lms24
approved these changes
Jul 28, 2026
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 28, 2026 17:23
0e43976 to
81a7bf1
Compare
Clears the type-aware errors that appeared once real program diagnostics were re-enabled: - Removes unnecessary type assertions and the now-unused type imports they leave behind (oxlint --fix), and drops a dead pino integration interface. - Consolidates the dedupe stacktrace/fingerprint guards so narrowing works without the old assignment-cast idiom. - Migrates the terser plugin from the deprecated `output` option to `format`. - Renames stale disable directives to the new rule names (`typescript-eslint(...)` -> `typescript/...`) for unbound-method and the HTTP_URL no-deprecated suppressions. - Adds no-deprecated suppressions where we intentionally read our own deprecated options for back-compat, and return-await suppressions where an await is deliberate (node-cron) or the cast makes the rule misfire.
…ssary `no-unnecessary-type-assertion` (tsgolint) reports several casts as redundant, but they are load-bearing: it only checks assignability at the cast site and misses that the cast changes the expression's resulting type for downstream use. Removing them type-checks locally but fails the real `tsc` build (verified: both tsconfig.json and tsconfig.types.json error identically without the cast). Restores each cast with a targeted suppression: a Cloudflare-only client option, LCP/INP PerformanceEntry fields, a Vue VNode probe, mysql/postgres vendored connection shapes, the view-hierarchy identifier, and the internal `shouldNotThrowOnFailure` on setCommits. eventbuilder instead uses a typed `Exception` variable so no cast (or suppression) is needed there.
Bumps the formatter and applies its reformatting in the following commit. Kept separate from the oxlint/tsgolint upgrade so the (purely mechanical) formatting diff stays contained.
logaretm
force-pushed
the
awad/oxfmt-reformat
branch
from
July 28, 2026 18:26
81a7bf1 to
2eb8e6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps oxfmt (0.38 to 0.60) and applies the resulting reformatting.