feat(remix)!: Remove import-in-the-middle instrumentation - #22815
Merged
Conversation
Migrate `@sentry/remix` server instrumentation fully to the channel-based path and drop the OpenTelemetry `RemixInstrumentation` module patcher, so the package no longer relies on the import-in-the-middle ESM loader hook. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
batman begin |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 368b96e. Configure here.
andreiborza
marked this pull request as ready for review
July 29, 2026 12:40
andreiborza
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
July 29, 2026 12:40
nicohrubec
approved these changes
Jul 29, 2026
Comment on lines
+29
to
+30
| // `match.route.id` / `match.params.*` mirror `RemixSemanticAttributes` from the OpenTelemetry | ||
| // `RemixInstrumentation` this integration replaced. |
Comment on lines
+106
to
+107
| * matched route (used to derive the `http.server` transaction name), mirroring the OpenTelemetry | ||
| * instrumentation's patch it replaced. |
andreiborza
enabled auto-merge (squash)
July 29, 2026 13:08
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrate
@sentry/remixserver instrumentation fully to the channel-based path.remixIntegration, removing the OpenTelemetry fallback and thespanStarthook that post-processed OTel spans.RemixInstrumentationand theinstrumentRemixWithOpenTelemetry/addRemixSpanAttributeshelpers.@opentelemetry/instrumentationand@opentelemetry/apidependencies.setupOnceform-data unit test onto the channel path.Why
Channel-based instrumentation is the default in v11 and node no longer registers the import-in-the-middle ESM loader hook. The OTel path in Remix was already unreachable at runtime, so removing it drops dead code and two unused OpenTelemetry dependencies.
Closes: #22774