ref(node)!: Remove @opentelemetry/instrumentation dependency - #22843
Draft
andreiborza wants to merge 1 commit into
Draft
ref(node)!: Remove @opentelemetry/instrumentation dependency#22843andreiborza wants to merge 1 commit into
@opentelemetry/instrumentation dependency#22843andreiborza wants to merge 1 commit into
Conversation
Member
Author
|
batman begin |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5681acc. Configure here.
Contributor
size-limit report 📦
|
andreiborza
commented
Jul 30, 2026
Comment on lines
+78
to
+79
| // All options below do not do anything anymore in this instrumentation, and will be removed in the future. | ||
| // They are only kept here for backwards compatibility - the respective functionality is now handled by the httpServerIntegration/httpServerSpansIntegration. |
Member
Author
There was a problem hiding this comment.
We have tracking issues for these, I just removed the unnecessary InstrumentationConfig from here.
andreiborza
force-pushed
the
ab/js-3203-remove-otel-instrumentation-from-node
branch
from
July 30, 2026 12:36
c89c176 to
94f3362
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 94f3362. Configure here.
This was referenced Jul 30, 2026
`@sentry/node` was the last package holding `@opentelemetry/instrumentation`. All instrumentation is now channel-based via orchestrion, so the surface this dependency backed is dead or a no-op: - `generateInstrumentOnce` (and the framework re-exports) had no call sites. - `ensureIsWrapped`'s shimmer-based check can no longer detect channel-based express/koa/hapi, so its warning and the `missing_instrumentation` context were removed, along with the `disableInstrumentationWarnings` option and the `MissingInstrumentationContext` type. - The `@sentry/node/import` ESM hook now only registers the orchestrion diagnostics-channel injection; the legacy iitm `@sentry/node/loader` entry was removed. Adds the `makeOrchestrionLoader` rollup util (import-only, delegates to `@sentry/server-utils/orchestrion/import-hook`). The legacy `makeOtelLoaders` util is kept temporarily so the framework SDKs still build until they migrate in the following PRs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/js-3203-remove-otel-instrumentation-from-node
branch
from
July 30, 2026 13:01
94f3362 to
1305111
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bottom of a stack. Removes the
@opentelemetry/instrumentationdependency from@sentry/node, the last package that still declared it.generateInstrumentOnceexport (and the framework re-exports of it).ensureIsWrappedand themissing_instrumentationcontext it set, plus the now-vestigialdisableInstrumentationWarningsoption andMissingInstrumentationContexttype from@sentry/core.InstrumentationConfigtypes in@sentry/node.@sentry/node/importan orchestrion-only diagnostics-channel hook; remove the legacy iitm@sentry/node/loaderentry.makeOrchestrionLoaderrollup util (import-only, delegates to@sentry/server-utils/orchestrion/import-hook). The legacymakeOtelLoadersutil is kept temporarily so the framework SDKs still build until they migrate in the PRs stacked on top of this one.Why
All instrumentation is channel-based via orchestrion, so nothing uses
@opentelemetry/instrumentationanymore.generateInstrumentOncehad no call sites, andensureIsWrapped's shimmer-based detection can't see channel-based express/koa/hapi, so its warning only produced false negatives. The@sentry/node/importhook already registered the orchestrion injection; the iitmregister()it also did instrumented nothing.Breaking change, part of the v11 major. Keeping
makeOtelLoadersin this PR keepsdevelopgreen as each framework migrates in its own follow-up PR.