feat!: Use function span op for terminal request handlers - #22871
Draft
msonnb wants to merge 1 commit into
Draft
Conversation
Migrate the terminal request-handler span ops across the server integrations to the cross-framework `function` op, and trace Hono's internal `app.request()` dispatch as an `http.server` span: - express: `request_handler.express` -> `function` - fastify: `request_handler.fastify` -> `function` - elysia: `request_handler.elysia` -> `function` - nestjs: `handler.nestjs` -> `function` - hono: `hono.request` -> `http.server` Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
msonnb
changed the title
function span op for terminal request handlersfunction span op for terminal request handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates the terminal request-handler span ops across the server integrations to the cross-framework
functionop, and traces Hono’s internalapp.request()dispatch as anhttp.serverspan:request_handler.expressfunctionrequest_handler.fastifyfunctionrequest_handler.elysiafunctionhandler.nestjsfunctionhono.requesthttp.serverDecisions
functionop rather than a framework-specificrequest_handler.*op, which was never a registered convention. Middleware phases keep themiddlewareop from the parent PR.app.request()is an internal HTTP dispatch (one sub-app calling another in-process), so it is semantically an inbound server request and is now traced ashttp.server. It keeps its distinctauto.http.hono.internal_requestorigin, which stays the reliable discriminator for these spans — thehono-4multi-fetch e2e assertions were switched from filtering on the (now-ambiguous)opto filtering on that origin.Part of #22446