feat(nuxt)!: Remove deprecated sourceMapsUploadOptions module option
#22875
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,20 +22,9 @@ export function setupSourceMaps( | |
| nuxt: Nuxt, | ||
| addVitePlugin: (plugin: Plugin[], options?: { dev?: boolean; build?: boolean }) => void, | ||
| ): void { | ||
| const isDebug = moduleOptions.debug; | ||
|
|
||
| const sourceMapsEnabled = moduleOptions.sourcemaps?.disable !== true; | ||
|
|
||
| // In case we overwrite the source map settings, we default to deleting the files | ||
| const shouldDeleteFilesFallback = { client: true, server: true }; | ||
|
|
@@ -62,11 +51,7 @@ export function setupSourceMaps( | |
| ? 'server-side' | ||
| : 'client-side'; | ||
|
|
||
| if (!moduleOptions.sourcemaps?.filesToDeleteAfterUpload) { | ||
| // eslint-disable-next-line no-console | ||
| console.log( | ||
| `[Sentry] We enabled \`'hidden'\` source maps for your ${enabledDeleteFallbacks} build. Source map files will be automatically deleted after uploading them to Sentry.`, | ||
|
|
@@ -131,65 +116,27 @@ function normalizePath(path: string): string { | |
| * | ||
| * Only exported for Testing purposes. | ||
| */ | ||
| export function getPluginOptions( | ||
| moduleOptions: SentryNuxtModuleOptions, | ||
| shouldDeleteFilesFallback?: { client: boolean; server: boolean }, | ||
| ): SentryVitePluginOptions | SentryRollupPluginOptions { | ||
| const sourcemapsOptions = moduleOptions.sourcemaps || {}; | ||
| const filesToDeleteAfterUpload = resolveFilesToDeleteAfterUpload(moduleOptions, shouldDeleteFilesFallback); | ||
|
|
||
| return { | ||
| applicationKey: moduleOptions.applicationKey, | ||
| org: moduleOptions.org ?? process.env.SENTRY_ORG, | ||
| project: moduleOptions.project ?? process.env.SENTRY_PROJECT, | ||
| authToken: moduleOptions.authToken ?? process.env.SENTRY_AUTH_TOKEN, | ||
| telemetry: moduleOptions.telemetry ?? true, | ||
| url: moduleOptions.sentryUrl ?? process.env.SENTRY_URL, | ||
| headers: moduleOptions.headers, | ||
| debug: moduleOptions.debug ?? false, | ||
| silent: moduleOptions.silent ?? false, | ||
| errorHandler: moduleOptions.errorHandler, | ||
| bundleSizeOptimizations: moduleOptions.bundleSizeOptimizations, // todo: test if this can be overridden by the user | ||
| release: { | ||
| name: moduleOptions.release?.name, | ||
| // Support all release options from BuildTimeOptionsBase | ||
| ...moduleOptions.release, | ||
| ...moduleOptions?.unstable_sentryBundlerPluginOptions?.release, | ||
|
|
@@ -206,21 +153,51 @@ export function getPluginOptions( | |
| // The server/client files are in different places depending on the nitro preset (e.g. '.output/server' or '.netlify/functions-internal/server') | ||
| // We cannot determine automatically how the build folder looks like (depends on the preset), so we have to accept that source maps are uploaded multiple times (with the vitePlugin for Nuxt and the rollupPlugin for Nitro). | ||
| // If we could know where the server/client assets are located, we could do something like this (based on the Nitro preset): isNitro ? ['./.output/server/**/*'] : ['./.output/public/**/*'], | ||
| assets: sourcemapsOptions.assets ?? undefined, | ||
| ignore: sourcemapsOptions.ignore ?? undefined, | ||
| filesToDeleteAfterUpload, | ||
| rewriteSources: sourcemapsOptions.rewriteSources ?? normalizePath, | ||
| ...moduleOptions?.unstable_sentryBundlerPluginOptions?.sourcemaps, | ||
| }, | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Users can set `filesToDeleteAfterUpload` themselves. If they don't, we fall back to deleting the | ||
| * client/server source maps — but only the ones Sentry generated itself (i.e. when the user didn't | ||
| * configure source maps at all). If the user explicitly set source maps, we leave their files alone. | ||
| */ | ||
|
Comment on lines
+165
to
+169
Member
There was a problem hiding this comment. Nuxt has no Maybe that's worth pointing out here. Also a link to the docs: https://nuxt.com/docs/4.x/api/nuxt-config#sourcemap |
||
| function resolveFilesToDeleteAfterUpload( | ||
| moduleOptions: SentryNuxtModuleOptions, | ||
| shouldDeleteFilesFallback?: { client: boolean; server: boolean }, | ||
| ): string | Array<string> | undefined { | ||
| const shouldDeleteFilesAfterUpload = shouldDeleteFilesFallback?.client || shouldDeleteFilesFallback?.server; | ||
| const fallbackFilesToDelete = [ | ||
| ...(shouldDeleteFilesFallback?.client ? ['.*/**/public/**/*.map'] : []), | ||
| ...(shouldDeleteFilesFallback?.server | ||
| ? ['.*/**/server/**/*.map', '.*/**/output/**/*.map', '.*/**/function/**/*.map'] | ||
| : []), | ||
| ]; | ||
|
|
||
| const filesToDeleteAfterUpload = moduleOptions.sourcemaps?.filesToDeleteAfterUpload; | ||
|
|
||
| if (typeof filesToDeleteAfterUpload === 'undefined' && shouldDeleteFilesAfterUpload && moduleOptions.debug) { | ||
| // eslint-disable-next-line no-console | ||
| console.log( | ||
| `[Sentry] Setting \`sentry.sourcemaps.filesToDeleteAfterUpload: [${fallbackFilesToDelete | ||
| // Logging it as strings in the array | ||
| .map(path => `"${path}"`) | ||
| .join(', ')}]\` to delete generated source maps after they were uploaded to Sentry.`, | ||
| ); | ||
| } | ||
|
|
||
| return filesToDeleteAfterUpload | ||
| ? filesToDeleteAfterUpload | ||
| : shouldDeleteFilesAfterUpload | ||
| ? fallbackFilesToDelete | ||
| : undefined; | ||
| } | ||
|
|
||
| /* There are multiple ways to set up source maps (https://github.com/getsentry/sentry-javascript/issues/13993 and https://github.com/getsentry/sentry-javascript/pull/15859) | ||
| 1. User explicitly disabled source maps | ||
| - keep this setting (emit a warning that errors won't be unminified in Sentry) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed hahaha