Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/cloudflare/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ export { defineCloudflareOptions } from './defineCloudflareOptions';
export { instrumentAgentWithSentry, instrumentDurableObjectWithSentry } from './durableobject';
export { sentryPagesPlugin } from './pages-plugin';

export { wrapRequestHandler } from './request';

export { CloudflareClient } from './client';
export { getDefaultIntegrations } from './sdk';

Comment thread
sentry[bot] marked this conversation as resolved.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { CloudflareOptions } from '@sentry/cloudflare';
import { setAsyncLocalStorageAsyncContextStrategy, wrapRequestHandler } from '@sentry/cloudflare';
import { setAsyncLocalStorageAsyncContextStrategy } from '@sentry/cloudflare';
import { wrapRequestHandler } from '@sentry/cloudflare/request';
import { debug, getDefaultIsolationScope, getIsolationScope, getTraceData } from '@sentry/core';
import type { H3Event } from 'h3';
import type { NitroApp, NitroAppPlugin } from 'nitropack';
Expand Down
2 changes: 1 addition & 1 deletion packages/sveltekit/src/worker/cloudflare.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import {
type CloudflareOptions,
getDefaultIntegrations as getDefaultCloudflareIntegrations,
setAsyncLocalStorageAsyncContextStrategy,
wrapRequestHandler,
} from '@sentry/cloudflare';
import { wrapRequestHandler } from '@sentry/cloudflare/request';
import { addNonEnumerableProperty } from '@sentry/core';
import type { Handle } from '@sveltejs/kit';
import { rewriteFramesIntegration } from '../server-common/integrations/rewriteFramesIntegration';
Expand Down
23 changes: 15 additions & 8 deletions packages/sveltekit/test/worker/cloudflare.test.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
import { beforeEach } from 'node:test';
import * as SentryCloudflare from '@sentry/cloudflare';
import { wrapRequestHandler } from '@sentry/cloudflare/request';
import type * as SentryCloudflareRequest from '@sentry/cloudflare/request';
import type { Carrier, GLOBAL_OBJ } from '@sentry/core';
import { describe, expect, it, vi } from 'vitest';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { initCloudflareSentryHandle } from '../../src/worker';

vi.mock('@sentry/cloudflare/request', async importOriginal => {
const actual = await importOriginal<typeof SentryCloudflareRequest>();
return { ...actual, wrapRequestHandler: vi.fn(actual.wrapRequestHandler) };
});

const globalWithSentry = globalThis as typeof GLOBAL_OBJ & Carrier;

function getHandlerInput() {
Expand All @@ -19,6 +25,7 @@ function getHandlerInput() {
describe('initCloudflareSentryHandle', () => {
beforeEach(() => {
delete globalWithSentry.__SENTRY__;
vi.mocked(wrapRequestHandler).mockClear();
});

it('sets the async context strategy when called', () => {
Expand All @@ -36,15 +43,15 @@ describe('initCloudflareSentryHandle', () => {
const { options, event, resolve, request, context } = getHandlerInput();

// @ts-expect-error - resolving an empty object is enough for this test
vi.spyOn(SentryCloudflare, 'wrapRequestHandler').mockImplementationOnce((_, cb) => cb());
vi.mocked(wrapRequestHandler).mockImplementationOnce((_, cb) => cb());

const handle = initCloudflareSentryHandle(options);

// @ts-expect-error - only passing a partial event object
await handle({ event, resolve });

expect(SentryCloudflare.wrapRequestHandler).toHaveBeenCalledTimes(1);
expect(SentryCloudflare.wrapRequestHandler).toHaveBeenCalledWith(
expect(wrapRequestHandler).toHaveBeenCalledTimes(1);
expect(wrapRequestHandler).toHaveBeenCalledWith(
{ options: expect.objectContaining({ dsn: options.dsn }), request, context, captureErrors: false },
expect.any(Function),
);
Expand All @@ -57,7 +64,7 @@ describe('initCloudflareSentryHandle', () => {
const locals = {};

// @ts-expect-error - resolving an empty object is enough for this test
vi.spyOn(SentryCloudflare, 'wrapRequestHandler').mockImplementationOnce((_, cb) => cb());
vi.mocked(wrapRequestHandler).mockImplementationOnce((_, cb) => cb());

const handle = initCloudflareSentryHandle(options);

Expand All @@ -74,14 +81,14 @@ describe('initCloudflareSentryHandle', () => {
delete event.platform;

// @ts-expect-error - resolving an empty object is enough for this test
vi.spyOn(SentryCloudflare, 'wrapRequestHandler').mockImplementationOnce((_, cb) => cb());
vi.mocked(wrapRequestHandler).mockImplementationOnce((_, cb) => cb());

const handle = initCloudflareSentryHandle(options);

// @ts-expect-error - only passing a partial event object
await handle({ event, resolve });

expect(SentryCloudflare.wrapRequestHandler).not.toHaveBeenCalled();
expect(wrapRequestHandler).not.toHaveBeenCalled();
expect(resolve).toHaveBeenCalledTimes(1);
});
});
Loading