feat: split childProcess integration into childProcess and worker integrations - #22886
feat: split childProcess integration into childProcess and worker integrations#22886atharv-sys32 wants to merge 1 commit into
Conversation
…egrations The childProcess integration handled both child process and worker thread events under one integration. This splits it into two: - childProcessIntegration: handles child process events only - workerIntegration: handles worker thread events only (new) The old childProcessIntegration's captureWorkerErrors option is deprecated. Users should use workerIntegration() instead. Fixes getsentry#18698 Signed-off-by: Atharv Pandey <atharvpandey245@gmail.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bab9d05. Configure here.
| .on('error', error => { | ||
| if (options.captureWorkerErrors !== false) { | ||
| captureException(error, { | ||
| mechanism: { type: 'auto.worker_thread', handled: false, data: { threadId: threadId !== undefined ? String(threadId) : undefined } }, |
There was a problem hiding this comment.
Stale worker mechanism in tests
High Severity
The worker error mechanism type changed to auto.worker_thread, but OnUncaughtException integration tests still expect auto.child_process.worker_thread. Those suites use default integrations, so they will assert the old type and fail.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit bab9d05. Configure here.
| export * as logger from './logs/exports'; | ||
|
|
||
| export { childProcessIntegration } from './integrations/childProcess'; | ||
| export { workerIntegration } from './integrations/workerIntegration'; |
There was a problem hiding this comment.
Incomplete dependent package exports
Medium Severity
workerIntegration is exported from @sentry/node, AWS, and Google Cloud, but not from @sentry/astro, which still manually re-exports childProcessIntegration. The exports consistency check also still ignores only childProcessIntegration for Bun, so Astro and Bun will fail that E2E assertion.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit bab9d05. Configure here.
1 participant
Fixes #18698