feat(core): Only check for native fetch in browser - #22893
Open
mydea wants to merge 1 commit into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b9bc3ac. Configure here.
| // falls back to an iframe DOM check to detect a polyfilled/wrapped `fetch` (which we don't want to | ||
| // double-instrument alongside XHR). Outside the browser there is no DOM, and `fetch` may be | ||
| // legitimately wrapped by the host (e.g. Next.js on Bun), so we always patch the global there. | ||
| if (isBrowser() && !supportsNativeFetch()) { |
There was a problem hiding this comment.
Feat PR lacks required tests
Medium Severity
This is a feat PR, but the diff has no integration or E2E test covering the new isBrowser()-gated native-fetch check in instrumentFetch. That violates the testing convention that feat PRs include at least one integration or E2E test. Without that, browser skip vs non-browser always-patch behavior can regress unnoticed.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit b9bc3ac. Configure here.
Member
Author
There was a problem hiding this comment.
this is tested in various places already.
Member
There was a problem hiding this comment.
Arguably this is a ref(core), I guess, since it's really not adding any user-facing feature, I guess?
Contributor
size-limit report 📦
|
mydea
marked this pull request as ready for review
July 31, 2026 07:58
JPeer264
approved these changes
Jul 31, 2026
Lms24
approved these changes
Jul 31, 2026
isaacs
approved these changes
Jul 31, 2026
| // falls back to an iframe DOM check to detect a polyfilled/wrapped `fetch` (which we don't want to | ||
| // double-instrument alongside XHR). Outside the browser there is no DOM, and `fetch` may be | ||
| // legitimately wrapped by the host (e.g. Next.js on Bun), so we always patch the global there. | ||
| if (isBrowser() && !supportsNativeFetch()) { |
Member
There was a problem hiding this comment.
Arguably this is a ref(core), I guess, since it's really not adding any user-facing feature, I guess?
isaacs
force-pushed
the
fn/native-fetch-check
branch
from
July 31, 2026 17:02
b9bc3ac to
ae94c1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this here: https://github.com/getsentry/sentry-javascript/pull/22869/changes
The flag for checking native flag is both incorrect I believe and also misleading. Some problems with it:
skipNativeFetchCheck && !supportsNativeFetch()would only check if we define that the check should be skipped?addFetchInstrumentationHandlerlevel, as this can be called multiple times butinstrumentFetchis only called once (whichever is the first caller) so that is also non ideal.Now, instead we simply guard this on
isBrowser()which imho makes more sense and is clearer.