Skip to content

ref(core): Deprecate include from RequestData - #22906

Merged
s1gr1d merged 3 commits into
developfrom
sig/requestdata-deprecate-include
Jul 31, 2026
Merged

ref(core): Deprecate include from RequestData#22906
s1gr1d merged 3 commits into
developfrom
sig/requestdata-deprecate-include

Conversation

@s1gr1d

@s1gr1d s1gr1d commented Jul 31, 2026

Copy link
Copy Markdown
Member

In favor of dataCollection

@s1gr1d
s1gr1d requested review from chargome and mydea July 31, 2026 09:58
Comment thread packages/core/src/integrations/requestdata.ts Outdated
@s1gr1d
s1gr1d force-pushed the sig/requestdata-deprecate-include branch from ff0c05d to e442d39 Compare July 31, 2026 10:32
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.82 kB - -
@sentry/browser - with treeshaking flags 28.02 kB - -
@sentry/browser (incl. Tracing) 47.08 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.09 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.82 kB - -
@sentry/browser (incl. Tracing, Replay) 86.39 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.83 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.11 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 103.76 kB - -
@sentry/browser (incl. Feedback) 47.14 kB - -
@sentry/browser (incl. sendFeedback) 34.66 kB - -
@sentry/browser (incl. FeedbackAsync) 39.77 kB - -
@sentry/browser (incl. Metrics) 30.89 kB - -
@sentry/browser (incl. Logs) 31.12 kB - -
@sentry/browser (incl. Metrics & Logs) 31.8 kB - -
@sentry/react 31.61 kB - -
@sentry/react (incl. Tracing) 49.33 kB - -
@sentry/vue 34.74 kB - -
@sentry/vue (incl. Tracing) 49.05 kB - -
@sentry/svelte 29.86 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 47.45 kB - -
CDN Bundle (incl. Logs, Metrics) 33.42 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 48.83 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.78 kB - -
CDN Bundle (incl. Tracing, Replay) 85.08 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.38 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 90.85 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.16 kB - -
CDN Bundle - uncompressed 95.11 kB - -
CDN Bundle (incl. Tracing) - uncompressed 142.34 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.82 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 146.32 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 224.58 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 261.6 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 265.56 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 275.3 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 279.26 kB - -
@sentry/nextjs (client) 51.92 kB - -
@sentry/sveltekit (client) 47.51 kB - -
@sentry/core/server 79.77 kB - -
@sentry/core/browser 51.7 kB - -
@sentry/node 121.41 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 84.91 kB +0.01% +1 B 🔺
@sentry/aws-serverless 93.19 kB - -
@sentry/cloudflare (withSentry) - minified 198.35 kB - -
@sentry/cloudflare (withSentry) 488.16 kB +0.09% +411 B 🔺

View base workflow run

* Controls what data is pulled from the request and added to the event.
* Defines what request data should be collected.
*
* @deprecated Use `dataCollection` from the `init()` options instead.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe be more specific how the old options map to the new dataCollection object or at least add a link where users can read more about this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a link. But this still stays in v11 and will likely only be removed in v12.

@s1gr1d
s1gr1d requested a review from a team as a code owner July 31, 2026 13:45
@s1gr1d
s1gr1d requested review from isaacs and removed request for a team July 31, 2026 13:45
@s1gr1d
s1gr1d enabled auto-merge (squash) July 31, 2026 13:45
@s1gr1d
s1gr1d merged commit f5b5370 into develop Jul 31, 2026
269 checks passed
@s1gr1d
s1gr1d deleted the sig/requestdata-deprecate-include branch July 31, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants