Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@

### Dependencies

- Bump Dotnet SDK from v5.16.1 to v6.5.0 ([#133](https://github.com/getsentry/sentry-powershell/pull/133))
- [changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md#650)
- [diff](https://github.com/getsentry/sentry-dotnet/compare/5.16.1...6.5.0)
- Bump Dotnet SDK from v5.16.1 to v6.8.0 ([#133](https://github.com/getsentry/sentry-powershell/pull/133), [#137](https://github.com/getsentry/sentry-powershell/pull/137))
- [changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md#680)
- [diff](https://github.com/getsentry/sentry-dotnet/compare/5.16.1...6.8.0)

## 0.4.0

Expand Down
2 changes: 1 addition & 1 deletion dependencies/Sentry.properties
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
version = 6.5.0
version = 6.8.0
repo = https://github.com/getsentry/sentry-dotnet

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The dependency upgrade to Sentry .NET SDK v6.8.0 may break reflection-based access to internal APIs like HttpTransportBase.ProcessEnvelope, causing initialization failures.
Severity: HIGH

Suggested Fix

Verify that the internal Sentry .NET SDK APIs accessed via reflection still exist and have the same signatures in v6.8.0. If they have changed, update the reflection code in SynchronousTransport.ps1 and New-HttpTransport.ps1 to match the new API. Consider adding tests that validate the reflection against the new SDK version to prevent future breakages.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: dependencies/Sentry.properties#L2

Potential issue: The `sentry-powershell` module uses reflection to access internal,
non-public APIs of the Sentry .NET SDK, including `HttpTransportBase.ProcessEnvelope`,
`HttpTransportBase.CreateRequest`, and `SdkComposer.CreateHttpTransport()`. This pull
request upgrades the SDK from v6.5.0 to v6.8.0. There is a risk that these internal
APIs, which are not part of the public contract, have changed between versions. If they
have, the reflection calls will fail during `Start-Sentry` initialization, throwing an
exception. This will be logged as a warning and may either cause the script to fail or
continue without the custom synchronous transport, depending on the
`SentryPowershellRethrowErrors` global flag.

Did we get this right? 👍 / 👎 to inform future reviews.

license = MIT
Loading