ref(data-collection): simplify database collection config to a plain boolean#6772
Merged
ericapisani merged 4 commits intoJul 8, 2026
Merged
Conversation
…boolean The `database` option was a nested `DatabaseCollectionUserOptions`/ `DatabaseCollectionBehaviour` TypedDict with a single `query_params` field, adding indirection for no benefit. Collapse it to a plain `bool`, matching `queues`.
…boolean The `database` option was a nested `DatabaseCollectionUserOptions`/ `DatabaseCollectionBehaviour` TypedDict with a single `query_params` field, adding indirection for no benefit. Collapse it to a plain `bool`, matching `queues`.
ericapisani
force-pushed
the
ep/update-database-config-to-boolean
branch
from
045fadc to
466a932
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 466a932. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ 90465 passed | ⏭️ 6302 skipped | Total: 96767 | Pass Rate: 93.49% | Execution Time: 313m 54s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2446 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.74% 89.76% +0.02%
==========================================
Files 192 193 +1
Lines 23823 23876 +53
Branches 8226 8244 +18
==========================================
+ Hits 21378 21430 +52
- Misses 2445 2446 +1
- Partials 1349 1351 +2Generated by Codecov Action |
alexander-alderman-webb
approved these changes
Jul 8, 2026
…sentry/sentry-python into ep/update-database-config-to-boolean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on getsentry/sentry-docs#18637