Skip to content

test: Add streaming tests to test_sampling#6784

Merged
sentrivana merged 5 commits into
masterfrom
ivana/test-sampling-span-streaming
Jul 8, 2026
Merged

test: Add streaming tests to test_sampling#6784
sentrivana merged 5 commits into
masterfrom
ivana/test-sampling-span-streaming

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

Description

Only ported tests that also make sense in streaming mode. For example, tests testing explicit sampled decisions as args to start_transaction were not ported.

Issues

Part of #5395

Reminders

@sentrivana sentrivana marked this pull request as ready for review July 8, 2026 13:01
@sentrivana sentrivana requested a review from a team as a code owner July 8, 2026 13:01
Comment thread tests/tracing/test_sampling.py Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0cc6fa5. Configure here.

Comment thread tests/tracing/test_sampling.py Outdated
Comment thread tests/tracing/test_sampling.py
@sentrivana sentrivana marked this pull request as draft July 8, 2026 13:03
Comment thread tests/tracing/test_sampling.py
@sentrivana sentrivana marked this pull request as ready for review July 8, 2026 13:06

@alexander-alderman-webb alexander-alderman-webb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sentrivana sentrivana enabled auto-merge (squash) July 8, 2026 13:10
@sentrivana sentrivana merged commit 07d8eb8 into master Jul 8, 2026
140 checks passed
@sentrivana sentrivana deleted the ivana/test-sampling-span-streaming branch July 8, 2026 13:15
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

90555 passed | ⏭️ 6302 skipped | Total: 96857 | Pass Rate: 93.49% | Execution Time: 313m 8s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +450
Passed Tests 📈 +450
Failed Tests
Skipped Tests

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2444 uncovered lines.
✅ Project coverage is 89.74%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.74%    89.74%        —%
==========================================
  Files          192       192         —
  Lines        23823     23823         —
  Branches      8226      8226         —
==========================================
+ Hits         21378     21379        +1
- Misses        2445      2444        -1
- Partials      1349      1348        -1

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants