Skip to content

fix(ios): Add wait logic for dSYM generation in Xcode build phase #5653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
antonis wants to merge 1 commit into
base: v8
Choose a base branch
from
Draft

fix(ios): Add wait logic for dSYM generation in Xcode build phase #5653

antonis wants to merge 1 commit into from
+619 −0

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Feb 11, 2026 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes a race condition where the upload script runs before dSYM files are fully generated, causing main app dSYM to be missing from Sentry.
This fix should avoid regressions like:

caused by #5617

💡 Motivation and Context

Fixes #5288

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@antonis antonis added the ready-to-merge Triggers the full CI test suite label Feb 11, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026 •
edited
Loading

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

  • fix(ios): Add wait logic for dSYM generation in Xcode build phase by antonis in #5653
  • chore(deps): update Bundler Plugins to v4.9.1 by github-actions in #5649
  • CI: update workflows with newer version of Xcode (+ iOS SDK) by alwx in #5635
  • chore(deps): update Android SDK to v8.32.0 by github-actions in #5633
  • chore(deps): bump getsentry/craft from 2.20.1 to 2.21.2 by dependabot in #5630
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.20.1 to 2.21.2 by dependabot in #5632
  • chore(deps): bump github/codeql-action from 4.32.0 to 4.32.2 by dependabot in #5631
  • feat(feedback): Add autoCorrect and spellCheck config to FeedbackWidget by sbs44 in #5627
  • fix(feedback): Deep merge custom styles with defaults in FeedbackWidget by sbs44 in #5625

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026 •
edited
Loading

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Fixes

- Add wait logic for dSYM generation in Xcode build phase ([#5653](https://github.com/getsentry/sentry-react-native/pull/5653))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against ea5902b

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 482.16 ms 503.20 ms 21.04 ms
Size 43.75 MiB 48.41 MiB 4.66 MiB

Baseline results on branch: v8

Startup times

Revision Plain With Sentry Diff
d382e88+dirty 449.86 ms 431.04 ms -18.82 ms
12fba4a+dirty 483.60 ms 514.49 ms 30.89 ms
2af2313+dirty 412.86 ms 428.31 ms 15.45 ms
fa0d109+dirty 429.60 ms 452.50 ms 22.90 ms
bc8a1ed+dirty 442.18 ms 476.27 ms 34.08 ms
7f6455d+dirty 409.48 ms 433.66 ms 24.18 ms
b4fa5b4+dirty 449.55 ms 481.50 ms 31.95 ms
d6aa223+dirty 543.40 ms 564.24 ms 20.84 ms
4d0472d+dirty 429.60 ms 457.96 ms 28.36 ms
206e87e+dirty 464.80 ms 504.68 ms 39.88 ms

App size

Revision Plain With Sentry Diff
d382e88+dirty 43.75 MiB 48.41 MiB 4.66 MiB
12fba4a+dirty 43.75 MiB 48.40 MiB 4.64 MiB
2af2313+dirty 43.75 MiB 48.41 MiB 4.66 MiB
fa0d109+dirty 43.75 MiB 48.40 MiB 4.64 MiB
bc8a1ed+dirty 43.75 MiB 48.08 MiB 4.33 MiB
7f6455d+dirty 43.75 MiB 48.41 MiB 4.66 MiB
b4fa5b4+dirty 43.75 MiB 48.08 MiB 4.33 MiB
d6aa223+dirty 43.75 MiB 48.55 MiB 4.80 MiB
4d0472d+dirty 43.75 MiB 48.41 MiB 4.66 MiB
206e87e+dirty 43.75 MiB 48.40 MiB 4.64 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1192.89 ms 1194.13 ms 1.23 ms
Size 3.38 MiB 4.76 MiB 1.38 MiB

Baseline results on branch: v8

Startup times

Revision Plain With Sentry Diff
d382e88+dirty 1214.17 ms 1212.22 ms -1.95 ms
d6aa223+dirty 1192.33 ms 1208.17 ms 15.84 ms
206e87e+dirty 1184.11 ms 1183.19 ms -0.92 ms
bc8a1ed+dirty 1194.70 ms 1201.18 ms 6.48 ms
12fba4a+dirty 1214.20 ms 1223.30 ms 9.09 ms
4d0472d+dirty 1203.83 ms 1212.10 ms 8.27 ms
7f6455d+dirty 1201.47 ms 1206.83 ms 5.36 ms
fa0d109+dirty 1216.02 ms 1220.67 ms 4.65 ms
b4fa5b4+dirty 1203.83 ms 1207.13 ms 3.30 ms
2af2313+dirty 1212.38 ms 1213.21 ms 0.83 ms

App size

Revision Plain With Sentry Diff
d382e88+dirty 3.38 MiB 4.76 MiB 1.38 MiB
d6aa223+dirty 3.38 MiB 4.67 MiB 1.29 MiB
206e87e+dirty 3.38 MiB 4.67 MiB 1.29 MiB
bc8a1ed+dirty 3.44 MiB 4.66 MiB 1.22 MiB
12fba4a+dirty 3.38 MiB 4.67 MiB 1.29 MiB
4d0472d+dirty 3.38 MiB 4.76 MiB 1.37 MiB
7f6455d+dirty 3.38 MiB 4.76 MiB 1.37 MiB
fa0d109+dirty 3.38 MiB 4.67 MiB 1.29 MiB
b4fa5b4+dirty 3.44 MiB 4.66 MiB 1.22 MiB
2af2313+dirty 3.38 MiB 4.76 MiB 1.38 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.93 ms 1216.82 ms 6.89 ms
Size 3.38 MiB 4.76 MiB 1.38 MiB

Baseline results on branch: v8

Startup times

Revision Plain With Sentry Diff
12fba4a+dirty 1209.43 ms 1217.08 ms 7.65 ms
7f6455d+dirty 1198.98 ms 1199.37 ms 0.39 ms
206e87e+dirty 1197.12 ms 1204.25 ms 7.13 ms
d382e88+dirty 1214.31 ms 1215.00 ms 0.69 ms
2af2313+dirty 1203.02 ms 1213.87 ms 10.85 ms
fa0d109+dirty 1206.81 ms 1205.38 ms -1.43 ms
b4fa5b4+dirty 1213.59 ms 1211.26 ms -2.33 ms
4d0472d+dirty 1210.70 ms 1222.23 ms 11.53 ms
bc8a1ed+dirty 1198.66 ms 1200.60 ms 1.94 ms
d6aa223+dirty 1216.76 ms 1213.40 ms -3.37 ms

App size

Revision Plain With Sentry Diff
12fba4a+dirty 3.38 MiB 4.67 MiB 1.29 MiB
7f6455d+dirty 3.38 MiB 4.76 MiB 1.37 MiB
206e87e+dirty 3.38 MiB 4.67 MiB 1.29 MiB
d382e88+dirty 3.38 MiB 4.76 MiB 1.38 MiB
2af2313+dirty 3.38 MiB 4.76 MiB 1.38 MiB
fa0d109+dirty 3.38 MiB 4.67 MiB 1.29 MiB
b4fa5b4+dirty 3.44 MiB 4.66 MiB 1.22 MiB
4d0472d+dirty 3.38 MiB 4.76 MiB 1.37 MiB
bc8a1ed+dirty 3.44 MiB 4.66 MiB 1.22 MiB
d6aa223+dirty 3.38 MiB 4.67 MiB 1.29 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 461.44 ms 521.56 ms 60.12 ms
Size 43.94 MiB 49.27 MiB 5.33 MiB

Baseline results on branch: v8

Startup times

Revision Plain With Sentry Diff
2af2313+dirty 409.42 ms 436.65 ms 27.23 ms
d382e88+dirty 362.92 ms 407.68 ms 44.76 ms
4d0472d+dirty 375.89 ms 448.61 ms 72.72 ms
43bdc8b+dirty 416.08 ms 447.81 ms 31.73 ms
7f6455d+dirty 378.08 ms 432.36 ms 54.28 ms
12fba4a+dirty 456.57 ms 462.90 ms 6.32 ms
d6aa223+dirty 436.98 ms 466.42 ms 29.44 ms
206e87e+dirty 416.94 ms 440.98 ms 24.04 ms
bc8a1ed+dirty 396.10 ms 426.80 ms 30.69 ms
b4fa5b4+dirty 382.09 ms 398.28 ms 16.19 ms

App size

Revision Plain With Sentry Diff
2af2313+dirty 43.94 MiB 49.27 MiB 5.33 MiB
d382e88+dirty 43.94 MiB 49.27 MiB 5.33 MiB
4d0472d+dirty 43.94 MiB 49.27 MiB 5.33 MiB
43bdc8b+dirty 43.94 MiB 49.27 MiB 5.33 MiB
7f6455d+dirty 43.94 MiB 49.27 MiB 5.33 MiB
12fba4a+dirty 43.94 MiB 49.22 MiB 5.29 MiB
d6aa223+dirty 43.94 MiB 49.38 MiB 5.44 MiB
206e87e+dirty 43.94 MiB 49.22 MiB 5.29 MiB
bc8a1ed+dirty 43.94 MiB 48.91 MiB 4.97 MiB
b4fa5b4+dirty 43.94 MiB 48.91 MiB 4.97 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alwx alwx Awaiting requested review from alwx alwx will be requested when the pull request is marked ready for review alwx is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman will be requested when the pull request is marked ready for review lucas-zimerman is a code owner

Assignees

No one assigned

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@antonis